#1817: Update LORENE library ------------------------------------+--------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: review Priority: minor | Milestone: ET_2017_05 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: parma ------------------------------------+---------------------------------------
Comment (by rhaas):
In line "36 unset LIBS" if gfortran is required, what about ifort? In line "125 # build some utilities available with the LORENE library" shouldn't the copying of utilities be done via the makefile where UTIL_DIR is defined so that eg it is re-created after wiping the exe directory (minor)? In line "13 $(SCRATCH_BUILD)/done/$(THORN): $(SRCDIR)/build.sh " you are removing the tarball and the patches from the build dependencies. Did this not work before? Otherwise it would seem good to re-build LORENE when the tarball or the patches are changed.
My comments with regards to thorn and implementation naming still apply.