#1248: SimFactory should not silently disable thorns -------------------------+-------------------------------------------------- Reporter: hinder | Owner: eschnett Type: defect | Status: new Priority: major | Milestone: Component: SimFactory | Version: Resolution: | Keywords: -------------------------+--------------------------------------------------
Comment (by eschnett):
You should be able to set "disabled-thorns =" in the [default] section of your defs.local.ini.
It is quite possible that this never benefitted you, because we were very careful only to add thorns to the Einstein Toolkit thorn list that work on the standard production systems. If you use thorns with potentially complex dependencies (e.g. PETSc that may not be available on some systems), of if you port the Einstein Toolkit to new architectures (e.g. Blue Gene/Q), then the ability to disable thorns is very useful.
Instead of printing a warning (nothing wrong with this), what you probably really want is to briefly check the parameter file upon job submission, so that you receive your error messages much earlier.
In your case, which thorn was disabled on what machine? How did you get around this? Presumably, it was a thorn that you needed -- was it disabled by mistake, or did you have to invest non-trivial effort to make it work? In the latter case, I would argue that disabled-thorns may have been useful to you, since it allowed you to use that machine (or get started there) without having to care about this thorn first.