#1817: Update LORENE library ------------------------------------+--------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: review Priority: minor | Milestone: ET_2017_05 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by rhaas):
Not having looked into this any further, I'd like to re-iterate my comments on this in different ET calls: since this breaks backwards compatibility to the old LORENE code (it cannot read files written by the old code. Does the LORENE C++ API also change?) I would prefer if the thorn was called LORENE2 and also implemented LORENE2. Ideally it should be able to compile both LORENE and LORENE2 into the same executable. If not possible (since we don't control the names of LORENE's externally visible symbols) then one could at least try that one at least receives an error before the final link stage (or not at all since the linker normally just ignore duplicate symbols [without --whole-archive]).