#719: Mailing lists could have a link to the archived version of the message --------------------------+------------------------------------------------- Reporter: hinder | Owner: knarf Type: enhancement | Status: assigned Priority: minor | Milestone: Component: Other | Version: Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by rhaas):
This has been a while. Alright, let me see. You should only look at the .2.patch files. Ie. Decorate.py.2.patch and HyperArch.py.2.patch. The other two files are older versions (and I cannot remove attachments from a ticket, so once the upload system adds a new version, I cannot remove the old one).
Decorate.py:: This patch is superseded by Decoreate.py.2.patch, which no longer assumes a {{{@}}} to be present and instead uses only {{{[A-Za-z0-9-]}}} which is actually too restrictive and will often fall back on just the serial number. Instead we should use this: {{{ def get_unique_id(self): """return a unique ID consisting of only path-safe characters constructed from either the Message-ID or the sequence number""" retval = "%06i" % (self.sequence,) try: if self.msgid and self.msgid != 'n/a': retval = re.sub('/', '_', self.msgid) except AttributeError: pass return retval }}} which replaces all "/" in the message id by "_" to make the ID usable as a file name.
HyperArch.py (really HyperArch.py.2.patch):: As for {{{d['archive_url']}}}: mailman's {{{decorate}}} function (defined in {{{Decorate.py}}}) will add anything that the administrator specifies in mailman's web interface (see https://www.gnu.org/software/mailman /mailman-admin/node18.html). This is the proper way to integrate this information into mailman rather than just hard-code it into the python code. It's also easier to code up :-).