#1671: ExternalLibraries/HDF5 ------------------------------------+--------------------------------------- Reporter: bmundim | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ExternalLibraries HDF5 ------------------------------------+---------------------------------------
Comment (by bmundim):
There are other issues in that configure.sh file as well. For example if we are building the HDF5 library then we use --with-zlib=${ZLIB_DIR} instead of what is suggested in their website, `--with-zlib=INCDIR,LIBDIR' (http://www.hdfgroup.org/ftp/HDF5/current/src/unpacked/release_docs/INSTALL), and we don't have the option --with-szlib=/Szip_Install_Directory set.
Also note that ${ZLIB_DIR} is used when building but $LIBZ_DIR when checking if we should link against zlib library.
To avoid further confusion and trying to stick to the perceived convention, wouldn't be better to rename LIBZ_DIR and LIBSZ_DIR to ZLIB_LIB_DIRS and SZLIB_LIB_DIRS, respectively? and maybe add the ZLIB_INC_DIRS to satisfy the requirement for configuring with `--with-zlib=INCDIR,LIBDIR' option?