#1769: External libraries: moving towards multiarch library directory structure ------------------------------------+--------------------------------------- Reporter: bmundim | Owner: Type: defect | Status: review Priority: major | Milestone: ET_2015_05 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ExternalLibraries HDF5 Multiarch ------------------------------------+---------------------------------------
Comment (by rhaas):
Once this is up for proper review: * these seem very useful, thank you for gettting this started * the functions in bash_utils.sh (I think the name could be improved to be more descriptive to eg refer to the external libraries) namely {{{find_files}}} and {{{find_libs}}} use a global variable {{{FOUND}}} to communicate the fact that {{{find_files}}} suceeded. Instead it may be better to have {{{find_files}}} return 0 or 1 depending on success or failure. * it reports "Could not find tar command." if the TAR variable is not set. This is slightly incorrect since TAR may well be set to an incorrect path in which case it also "does not find tar" later on (the behaviour matches what the current detect.sh scripts do however). * a possible inprovement above using {{{set_make_vars}}} would be to have the functions use echo to output the variable definition along the lines "HDF5_LIBS=hdf5" so that the caller can use eval to activate them (same as eg ssh-agent does). This avoids using global variables to transfer function results. One can use {{{if ! vars=function ; then echo "Failure" ; fi}}} to assign the returned string to vars and catch errors at the same time.