#1796: Include IllinoisGRMHD into the Toolkit, as an Arrangement ------------------------------------+--------------------------------------- Reporter: zachetie@… | Owner: Zachariah Etienne Type: enhancement | Status: new Priority: major | Milestone: ET_2015_11 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: GRMHD IllinoisGRMHD ------------------------------------+---------------------------------------
Comment (by hinder):
There are also some tips on writing Cactus test cases at https://docs.einsteintoolkit.org/et-docs/adding_a_test_case.
Typically, we require a thorn to have test cases before being added to the toolkit. This is part of the "value proposition" that comes from being in the toolkit; people should expect that a certain level of quality assurance and software good practice has been applied to the components of the toolkit. However, these tests are not required to be comprehensive. Would it be relatively straightforward to add at least a minimal test to each thorn that tests its primary functionality? Or could you argue that these thorns are tested by other thorns with test cases which make use of them?