#994: read EOS table on single process the broadcast ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: EOS_Omni ------------------------------------+---------------------------------------
Comment (by eschnett):
I do not understand this patch.
- Where is the if statement that prevents the HDF5 calls if !do_IO? - sizeof *(VAR) is probably 8 (for double), not the size of the whole table - Ideally, the MPI_Bcast would use MPI_DOUBLE, not MPI_BYTE - I would rename "read_table_on_this_process" to "reader_process", since the former sounds like a boolean flag