#321: show-output is broken -------------------------+-------------------------------------------------- Reporter: eschnett | Owner: mthomas Type: defect | Status: closed Priority: critical | Milestone: Component: SimFactory | Version: Resolution: fixed | Keywords: -------------------------+-------------------------------------------------- Changes (by mthomas):
* status: new => closed * resolution: => fixed
Comment:
this has been fixed as of revision r1258. This would have been something that any contributor to simfactory could have fixed with very little effort. While I am more then happy to correct these problems, and most of them are my mistakes (I'll admit that freely), since there's a big push towards contribution, a bit of effort here would be appreciated.
Somehow, the show_output command was renamed to show_display. It was correctly renamed in simrestart.py to show_display as well. This change was wrong -- I'm really not sure why it was renamed from show_output to show_display. Anyway, the CommandDispatch function inside of each sim-*py file looks at known_commands data structure present, and attempts to run the function command_(command-name) with dashes replaced by underscores, so for this specific instance, the command show-output is attempted to be run as command_show_output. Since show_output was renamed to show_display (still confused by this, it might have been a side effect of a find/replace regex), it was attempted to run command_show_output, but it didn't exist, as it was renamed command_show_display.
Please, contributors, attempt to investigate crashes/errors yourself and identify if its an easy solution. If it is, please go ahead and commit a fix yourself, especially if its a blocker/critical issue.