#490: McLachlan test case failing due to ADMBase variable differences ------------------------------------+--------------------------------------- Reporter: hinder | Owner: eschnett Type: defect | Status: review Priority: critical | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: McLachlan ------------------------------------+---------------------------------------
Comment (by rhaas):
I compared schedules with and without the patch and the scheduling of the GRHydro routines does not change. Most of the GRHydro patch had already been applied (in r264 by me). I have attached a reduced patch that applies cleanly. Schedule changes between -r259 (before any GRHydro schedule changes) and with grhydro[2].diff are small, only moving GRHydro_AtmosphereReset out of MoL_Evolution with only sync_GRHydro_C2P_failed slipping in between. So the patch(es) can be applied. Note however #523 on issues with MoL_PostStepModify ordering and that maybe having a dedicated MoL_PostFullStep for final cleanup before MoL_Evolution leaves would reduce the danger of unexpected routines slipping in between MoL_Evolution and AtmosphereReset (and therefore occasionally picking up wrong values for the hydro variables).