#114: per-variable tolerances for Cactus testsuites --------------------------+------------------------------------------------- Reporter: knarf | Owner: tbode Type: enhancement | Status: review Priority: major | Milestone: ET_2011_10 Component: Cactus | Version: Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by knarf):
I agree that an option to print the tolerances used would be useful.
I don't understand your argument with the entire file name though. The problematic case I see is when you want to set the tolerance for all files to some value, but the tolerance of some other groups to other tolerances. The other files should not be a problem, but the regex for "all others" in this case cannot be .* because that would match everything. It would need to contain essentially all other regexes negated - which would also be error prone if someone changes one but forgets about the corresponding negation.
For example {{{ ABSTOL 1e-5 ABSTOL 1e-10 Psi[0-9] }}} would not be allowed with the current patch, because the {{{Psi[0-9]}}} files also match the first line. In this case you would have to write a regex which specifies 'everything but something matching {{{Psi[0-9]}}}. And now imagine something more complex like {{{ ABSTOL 1e-10 Psi[0-9] ABSTOL 1e-12 g[xyz] ABSTOL 1e-4 (.*)*.x.asc ABSTOL 1e-13 .* }}} Certainly all files of numbers 1-3 match also number 4, but files matching 2 might also match 3. Getting this group exclusive would make it hard to read.