#1260: list registered variables when exceeding MoL accumulator limit ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: MoL ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: review => reviewed_ok
Comment:
I don't understand your argument agains Util_asnprintf. You would call it multiple times, instead of snprintf, the only difference would be that you don't have to call malloc/realloc yourself.
You could also add a C++ file that uses a string stream.
However, the routine is small, and the complex logic is contained in it. Either way to generate a string is fine.
CCTK_FullName returns a char*, not a const char*. You should change the variable declaration. This will also remove the need for the void* cast in the call to free.
I would move the declaration of off to just before the second loop.