#900: GRHydro: do not use the Slopelimiter function ------------------------------------+--------------------------------------- Reporter: bmundim | Owner: bmundim Type: defect | Status: review Priority: minor | Milestone: ET_2012_05 Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro slopelimiter ------------------------------------+---------------------------------------
Comment (by bmundim):
Reading the email archive: the bugfix is in SUPERBEE, the other changes
simply remove limiters which we suspect to be wrong but don't care enough about to actually fix, yes?
Not quite. If I remember correctly vanleerMC was actually an implementation of minmod.
The patch seems to not have a final "else" clause anymore which is
generally a bad idea (since one should never assume no one will ever add a case "d" to the cases "a", "b", "c" we are testing for). The removed slopelimiter had such a line:
Isn't the else clause essentially already checked at GRHydro_ParamCheck.F90? If we type a tvd_limiter that is not in the list at param.ccl, the code is aborted.
In any case, I added the simple logic to abort if using the deprecated values of tvd_limiters. Please let me know if it is ok to apply.