#1894: EinsteinInitialData/TwoPunctures segfaults and miscalcs with SP, maybe DP too. ---------------------------------+------------------------------------------ Reporter: koppel@… | Owner: Type: defect | Status: reopened Priority: unset | Milestone: Component: Other | Version: development version Resolution: | Keywords: ---------------------------------+------------------------------------------ Changes (by rhaas):
* status: review => reopened
Comment:
Looks mostly ok to me. Minor issues that should be addressed:
* layout of whitespace in the clamp routine should mimic what TwoPunctures' other code uses * I would rename the routine clamptoone to make it clear to which range it clamps * I would add a comment to the clamp on tan() stating that yes indeed the result of this compuation (ie B) is expected to be in the range of [-1,1] which tan is not normally guaranteed to be