#877: EinsteinExact arrangement should be added to the Einstein Toolkit ------------------------------------+--------------------------------------- Reporter: hinder | Owner: Type: task | Status: reviewed_ok Priority: major | Milestone: ET_2012_05 Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by bmundim):
4) In the documentation it says that the code ignores
initial_shift, initial_lapse, initial_dtshift and initial_dtlapse. Per example above, I don't think this is true.
It ignores initial_shift, initial_lapse, initial_dtshift and
initial_dtlapse. The setting of the initial data for all of the ADMBase variables is determined only by the initial_data parameter.
I am not sure I understood you here. The parameter file does need to
set initial_lapse, etc, to ShiftedGaugeWave (otherwise it uses ADMBase defaults). So how come ShiftedGaugeWave is ignoring those parameters? It extends them indeed.
The current situation is that the thorns extend all the parameters:
ADMBase::initial_data, ADMBase::initial_lapse, ADMBase::initial_shift, ADMBase::initial_dtlapse, ADMBase::initial_dtshift, ADMBase::evolution_method. There are two scheduled functions in each thorn, one which is conditionally scheduled depending on ADMBase::initial_data being set to the thorn name and the other which is conditionally scheduled depending on ADMBase::evolution_method being set to the thorn name. Both of these functions unconditionally set all of the ADMBase variables (lapse, shift, three-metric, extrinsic curvature, dtlapse and dtshift). Ideally this should be improved at some point so that the other ADMBase parameters are queried before setting the relevant variables.
Ok, now I understand what you mean by "being ignored" by the code. However if we don't set, for example, ADMBase::initial_dtlapse in the parameter file then it is set to its ADMBase default, "none", and end up not allocating storage for that variable (as far as I understood). At the end we do need to set them all in the parameter file.