[Einstein Toolkit] #1394: simfactory does not return "nice" error message when local rsync version cannot be determined
#1394: simfactory does not return "nice" error message when local rsync version cannot be determined ------------------------+--------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: defect | Status: new Priority: minor | Milestone: Component: SimFactory | Version: development version Keywords: | ------------------------+--------------------------------------------------- currently, when the version of the local rsync executable cannot be determined (eg because the user has no executable privileges or because the regular expression did not match) the user is left with a python backtrace into lib/simlib.py/RsyncVersion stating that NoneType has no attribute groups.
The attached patch checks if the regular expression matched and if not reports a fatal error including rsync's return text in the error message.
#1394: simfactory does not return "nice" error message when local rsync version cannot be determined -------------------------+-------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: defect | Status: review Priority: minor | Milestone: Component: SimFactory | Version: development version Resolution: | Keywords: -------------------------+-------------------------------------------------- Changes (by rhaas):
* status: new => review
#1394: simfactory does not return "nice" error message when local rsync version cannot be determined -------------------------+-------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: defect | Status: reviewed_ok Priority: minor | Milestone: Component: SimFactory | Version: development version Resolution: | Keywords: -------------------------+-------------------------------------------------- Changes (by eschnett):
* status: review => reviewed_ok
Comment:
Approved.
No need for an else branch; fatal will not return.
#1394: simfactory does not return "nice" error message when local rsync version cannot be determined -------------------------+-------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: defect | Status: closed Priority: minor | Milestone: Component: SimFactory | Version: development version Resolution: fixed | Keywords: -------------------------+-------------------------------------------------- Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
applied as rev 2121 of simfactory.
I left the (superfluous) "else" in so that the code logic matches what is done in GetCactusFile (purely aesthetic).
trac@lists.einsteintoolkit.org
-
Einstein Toolkit