#1391: Remove old code in radiative boundary condition in Boundary -----------------------------------+---------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: new Priority: optional | Milestone: Component: EinsteinToolkit thorn | Version: development version Keywords: | -----------------------------------+---------------------------------------- I stumbled across code which we should remove. I don't see anything using this particular feature, and never have. It was marked as 'to be deprecated' 10 years ago.
#1391: Remove old code in radiative boundary condition in Boundary ------------------------------------+--------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: review Priority: optional | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by knarf):
* status: new => review
#1391: Remove old code in radiative boundary condition in Boundary ------------------------------------+--------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: reviewed_ok Priority: optional | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: review => reviewed_ok
Comment:
Approved.
Does this invalidate any existing code, or existing test cases? We probably have some pre-MoL code left over.
Does the documentation also need to be updated?
#1391: Remove old code in radiative boundary condition in Boundary ------------------------------------+--------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: reviewed_ok Priority: optional | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by knarf):
I didn't find the string "PREVIOUS_TIME_LEVEL" anywhere in my source checkout (which is larger than the ET), other than in this section of the code. The question here isn't about pre-MoL code. That is fine. The code in question looks for a possibility to declare which variable the previous timelevel of another variable is by table entry and name/index lookup, as opposed to the now used *_p naming scheme. Up to yesterday I didn't even know this possibility existed once. :)
#1391: Remove old code in radiative boundary condition in Boundary ------------------------------------+--------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: reviewed_ok Priority: optional | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by eschnett):
Thorn ADM uses this scheme: it defines different variables for current and previous time levels.
However, thorn ADM also uses the outdated API for thorn Boundary, so it does not use tables yet, and thus doesn't use "previous_time_level" either. Thorn ADM is too old to know about "previous_time_level", so yes, it can be safely removed...
#1391: Remove old code in radiative boundary condition in Boundary ------------------------------------+--------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: reviewed_ok Priority: optional | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by rhaas):
This might be an reason to also retire ADM to CactusArchive since it is not used by anyone (as far as I know) and we were only keeping it around since some tests use it and re-writing the tests is more work than keeping ADM around?
#1391: Remove old code in radiative boundary condition in Boundary ------------------------------------+--------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: closed Priority: optional | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: fixed | Keywords: ------------------------------------+--------------------------------------- Changes (by knarf):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Committed as of r319. As to ADM: yes, it should be archived at some point. However, this is not related to this issue, so I am closing nevertheless.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit