[Einstein Toolkit] #1624: remove MOLDOESCOMPLEX from MoL

List overview All Threads
Download

newer

older

[Einstein Toolkit] #1742:...

[Einstein Toolkit] #1518:...

Einstein Toolkit

27 May 2014 27 May '14

10:43 a.m.

#1624: remove MOLDOESCOMPLEX from MoL -----------------------------------+---------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: new Priority: optional | Milestone: Component: EinsteinToolkit thorn | Version: development version Keywords: | -----------------------------------+---------------------------------------- MOLDOESCOMPLEX is an old #define in MoL, and seems to be unused for quite some time now. It also comes with the comment "even using it probably doesn't work" in the commit. I suggest to remove it (removing the code within).

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1624 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Show replies by date

Einstein Toolkit

27 May 27 May

10:43 a.m.

New subject: [Einstein Toolkit] #1624: remove MOLDOESCOMPLEX from MoL

#1624: remove MOLDOESCOMPLEX from MoL ------------------------------------+--------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: review Priority: optional | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by knarf):

* status: new => review

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1624#comment:1 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

3 Jun 3 Jun

10:25 a.m.

New subject: [Einstein Toolkit] #1624: remove MOLDOESCOMPLEX from MoL

#1624: remove MOLDOESCOMPLEX from MoL ------------------------------------+--------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: reviewed_ok Priority: optional | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):

* status: review => reviewed_ok

Comment:

Yes, this should be removed.

In the long term, all linear operations should be performed via MoL_LinearCombination. This routine should be extended to support complex variables as well.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1624#comment:2 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

10:41 a.m.

New subject: [Einstein Toolkit] #1624: remove MOLDOESCOMPLEX from MoL

#1624: remove MOLDOESCOMPLEX from MoL ------------------------------------+--------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: reviewed_ok Priority: optional | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------

Comment (by eschnett):

Actually, this is already implemented in MoL_LinearCombination.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1624#comment:3 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

26 Jan 26 Jan

9:41 a.m.

New subject: [Einstein Toolkit] #1624: remove MOLDOESCOMPLEX from MoL

#1624: remove MOLDOESCOMPLEX from MoL ------------------------------------+--------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: reopened Priority: optional | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by knarf):

* status: reviewed_ok => reopened

Comment:

https://bitbucket.org/cactuscode/cactusnumerical/pull-request/1/mol- remove-not-working-direct-support-for/diff

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1624#comment:4 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

9:42 a.m.

New subject: [Einstein Toolkit] #1624: remove MOLDOESCOMPLEX from MoL

* status: reopened => review

Comment:

Please someone review the quite extensive deletions. It is a lot, but it should be fast (a lot of repetition).

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1624#comment:5 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

10:54 a.m.

New subject: [Einstein Toolkit] #1624: remove MOLDOESCOMPLEX from MoL

Comment (by hinder):

Do the ET tests pass when this change is made?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1624#comment:6 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

11:01 a.m.

New subject: [Einstein Toolkit] #1624: remove MOLDOESCOMPLEX from MoL

Comment (by knarf):

I only tested on my machine, and there they do.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1624#comment:7 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

2 Feb 2 Feb

9:58 a.m.

New subject: [Einstein Toolkit] #1624: remove MOLDOESCOMPLEX from MoL

#1624: remove MOLDOESCOMPLEX from MoL ------------------------------------+--------------------------------------- Reporter: knarf | Owner: Type: enhancement | Status: closed Priority: optional | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: fixed | Keywords: ------------------------------------+--------------------------------------- Changes (by knarf):

* status: review => closed * resolution: => fixed

Comment:

Merged

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1624#comment:8 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

4267

Age (days ago)

4518

Last active (days ago)

trac@lists.einsteintoolkit.org

8 comments

1 participants

tags (0)

participants (1)

Einstein Toolkit