#1742: suggested naming convention for Cactus thorn files -------------------------+-------------------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: new Priority: optional | Milestone: Component: Cactus | Version: development version Keywords: | -------------------------+-------------------------------------------------- urrently the user guide (http://einsteintoolkit.org/documentation/UsersGuide/UsersGuidech9.html#x13-1...) suggests prefixing file names with the thorn name, ie.
MyThorn_Functions.c
I was wondering what the rationale behind this is. There is no chance of conflicts during the build since each thorn is build in a subdirectory of its own. The extra prefix makes all filenames longer without adding anything to the functionality it seems to me.
In order to shorten the filenames and unclutter directory listings I would like remove the recommendation from the user guide.
Pull request is at: https://bitbucket.org/cactuscode/cactus/pull-request/8 /suggested-naming-convention-for-cactus/diff
#1742: suggested naming convention for Cactus thorn files --------------------------+------------------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: optional | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by rhaas):
* status: new => review
Comment:
Ian H
#1742: suggested naming convention for Cactus thorn files --------------------------+------------------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: optional | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by knarf):
I agree. The wording could/should maybe add Fortran module names. These all end up in the common scratch directory, and without proper module naming people can get into trouble.
#1742: suggested naming convention for Cactus thorn files --------------------------+------------------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: closed Priority: optional | Milestone: Component: Cactus | Version: development version Resolution: fixed | Keywords: --------------------------+------------------------------------------------- Changes (by rhaas):
* status: review => closed * resolution: => fixed
Comment:
Applied in git hash 7744e3541d2d3664a030fea8713a8f647c051546 of the flesh.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit