[Einstein Toolkit] #678: Don't output build details for external libraries

List overview All Threads
Download

newer

older

Re: [ET Trac] [Users] [Einstein...

[Einstein Toolkit] #578: Vectorize...

Einstein Toolkit

25 Nov 2011 25 Nov '11

12:05 p.m.

#678: Don't output build details for external libraries -----------------------------------+---------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: | -----------------------------------+---------------------------------------- When an external library is built, Cactus always outputs all details of the build process. Much of this should be suppressed (in particular checking whether to build the library) unless VERBOSE is set.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/678 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Show replies by date

Einstein Toolkit

11 Dec 11 Dec

8:15 p.m.

#678: Don't output build details for external libraries ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):

* status: new => review

Comment:

I attach a patch that modifies thorn FFTW3. Please review this; I will then implement the corresponding changes in the other ExternalLibraries thorns as well.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/678#comment:1 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

12 Dec 12 Dec

4:17 a.m.

Comment (by barry.wardell):

This is certainly an improvement, but there is still quite a lot of unnecessary output. For example, the pushd and popd commands echo to standard output, so this should probably be redirected to /dev/null.

I would suggest using a different word than "enclosed". Perhaps "bundled" would be better?

The standard output from the external library configure and build process is still output. Should this also be silenced unless verbose is set? I would say yes as this information is typically much less relevant than the actual Cactus build information.

For me, the output from inside BEGIN MESSAGE ... END MESSAGE is delayed until after the build process has finished, making it worse than useless as it then leads to confusing messages like:

FFTW3: Preparing directory structure... FFTW3: Unpacking archive... FFTW3: Configuring... FFTW3: Building... FFTW3: Installing... FFTW3: Cleaning up... FFTW3: Done. FFTW3 selected, but FFTW3_DIR not set. Checking some places... FFTW3 not found Using enclosed FFTW3... Building FFTW3

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/678#comment:2 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

9:45 a.m.

Comment (by eschnett):

I thought about disabling all output from configure and make as well, but I now think this is too much. Building an external library may take a long time, there may be errors (especially if the compiler or compiler flags in Cactus are not configured correctly), and it seems standard in other projects as well to show the output of sub-configures and sub makes.

Given that we show this, disabling the output of pushd and popd doesn't make sense (just two more lines).

We can change "enclosed" to "bundled".

Yes, the order of the output is wrong. This is #695.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/678#comment:3 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

6:02 p.m.

Comment (by barry.wardell):

Replying to [comment:3 eschnett]:

...

I thought about disabling all output from configure and make as well,

but I now think this is too much. Building an external library may take a long time, there may be errors (especially if the compiler or compiler flags in Cactus are not configured correctly), and it seems standard in other projects as well to show the output of sub-configures and sub makes.

In that case one can always build with verbose output. Even better would be for verbose output to always be redirected to a log file with only the simplified output printed to stdout. This is how, e.g., MacPorts works and I quite like it.

Either way, the proposed patch is certainly an improvement on the current situation, so I would be in favor of committing it either with or without the total silencing of the external library build process.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/678#comment:4 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

6:10 p.m.

Comment (by rhaas):

pleas don't make output _only_ available in some file. This breaks the "make" command in vim (and emacs I guess) since they parse the output of 'make'. Having half the information in one file and half in another renders this useless or at least means that one has to look at several files and try to decide how to interleave the lines of output.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/678#comment:5 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

14 Dec 14 Dec

5:33 a.m.

Comment (by barry.wardell):

I was thinking more along the lines of all output being sent to a single log file, with only the "useful" information printed to standard output. In the case of external libraries, "useful" means anything inside the BEGIN MESSAGE...END MESSAGE blocks (is there any use for these blocks other than this?). Would this still cause problems for you?

I don't feel all that strongly about this. My preference would be for quieter output, but I am also OK with something along the lines of Erik's patch.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/678#comment:6 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

5:53 a.m.

Comment (by rhaas):

I'd like VERBOSE=yes to (at least also) output to stdout if possible, otherwise there seems to be no way at all to get a single file with all output from the build process. If I use VERBOSE=yes I expect lots of output and would consider all of it useful (for VERBOSE=yes). For VERBOSE=no I am fine if stdout of ExternalLibraries ends up only in some file. stderr should go to the console though (to not hide errors), I think.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/678#comment:7 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

5:59 a.m.

Comment (by barry.wardell):

Yes, I agree that with verbose output enabled everything should go to standard output. I forgot to say that my quieter output suggestion should only apply in the non-verbose case.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/678#comment:8 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

6:01 a.m.

Comment (by rhaas):

Fine with me as long as VEBOSE ouputs everything to stdout/stderr I can always use VERBOSE if I make changes to an ExternalLibrary and want to see its configure output. :-)

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/678#comment:9 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

15 Dec 15 Dec

10:44 a.m.

#678: Don't output build details for external libraries ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):

* status: review => closed * resolution: => fixed

Comment:

I applied this and equivalent patches to ExternalThorns.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/678#comment:10 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

5412

Age (days ago)

5432

Last active (days ago)

trac@lists.einsteintoolkit.org

10 comments

1 participants

tags (0)

participants (1)

Einstein Toolkit