#1148: New thorn CactusTest/TestCrayPointers -----------------------------------+---------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: | -----------------------------------+---------------------------------------- I want to add a thorn CactusTest/TestCrayPointers that tests whether the Cray pointer syntax is accepted by the Fortran compiler. If so, please create the respective repository.
#1148: New thorn CactusTest/TestCrayPointers ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: new => review
#1148: New thorn CactusTest/TestCrayPointers ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by hinder):
I think we have too many test thorns. Can you create a single thorn which contains a larger number of tests?
#1148: New thorn CactusTest/TestCrayPointers ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by rhaas):
Since we plan to use this feature in the flesh eventually, we might want to not add such a test right now but instead rely on autoconf to detect this for us once we add that feature. If autoconf fails then we must fall- back to the current scheme of calling Fortran thorns. We then would need no specific test case since all Cactus thorns will be tests I think.
#1148: New thorn CactusTest/TestCrayPointers ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by eschnett):
Regarding "too many thorns": Please suggest another thorn into which to fold this test. All other thorns relate to certain features, and none subsume Cray pointers. We could conceivably merge test thorns, but I suggest to not make this a prerequisite for testing Cray pointers, as these are independent issues.
Regarding autoconf: Autoconf support for Fortran is meagre. One can use Fortran 77 only, and this only because Cactus extends certain autoconf macros that otherwise support only C or C++. (We are using a very old version of autoconf.) I just checked, and running a Cray pointer test via autoconf is not trivial, as Fortran compiler flags seem to get lost. Testing the C/Fortran calling interface is also not possible from autoconf, since this is determined later (and basically outside autoconf).
I believe this thorn has value as-is, if only to allow us get feedback about systems where Cray pointers don't work before we use them.
#1148: New thorn CactusTest/TestCrayPointers ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by hinder):
Why not have a single thorn which contains all these tests? I think these thorns logically test features of the flesh, which is often thought of as a thorn called "Cactus". Why not just have a thorn called CactusTest in the CactusBase arrangement which contains all these tests? Then we wouldn't have to keep creating repositories for every new class of test for the flesh. Thoughts?
#1148: New thorn CactusTest/TestCrayPointers ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by rhaas):
Fewer test thorns would make sense. A number of these tests in this arrangement test compile time errors as well as of run time errors (eg. the Cray pointer one would do so, and the testloop thorns also test compile time errors).
#1148: New thorn CactusTest/TestCrayPointers ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by bmundim):
While I agree that grouping several tests in one thorn may be beneficial, I think the discussion in this line goes beyond the scope of this ticket. I would add this proposed thorn to the ET thornlist and open a new ticket where we could put our thoughts together on what needs to be done to group all the tests in one single thorn, if we really decide to do so.
#1148: New thorn CactusTest/TestCrayPointers ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by anonymous):
I agree.
#1148: New thorn CactusTest/TestCrayPointers ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: review => closed * resolution: => fixed
Comment:
Applied.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit