#1013: Don't log in multiple times for sim sync -------------------------+-------------------------------------------------- Reporter: eschnett | Owner: eschnett Type: enhancement | Status: new Priority: major | Milestone: Component: SimFactory | Version: Keywords: | -------------------------+-------------------------------------------------- Don't log in twice for "sim sync". This is necessary only to create the sourcebasedir if it does not yet exist, which is necessary only very rarely. Instead, try rsync directly, and if it fails, examine the error message and create the directory if necessary.
This makes simfactory much nicer to use when one cannot setup an ssh agent, i.e. when one has to type in the password or use a token eavery time.
#1013: Don't log in multiple times for sim sync --------------------------+------------------------------------------------- Reporter: eschnett | Owner: eschnett Type: enhancement | Status: review Priority: major | Milestone: Component: SimFactory | Version: Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):
* status: new => review
Comment:
The attached patch first calls rsync, and if it fails, calls mkdir, then rsync again.
#1013: Don't log in multiple times for sim sync --------------------------+------------------------------------------------- Reporter: eschnett | Owner: eschnett Type: enhancement | Status: review Priority: major | Milestone: Component: SimFactory | Version: Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by barry.wardell):
This looks good to me. I quickly tested the patch and it seems to work fine. An added bonus is that syncing is now a second or so faster! Please commit.
#1013: Don't log in multiple times for sim sync --------------------------+------------------------------------------------- Reporter: eschnett | Owner: eschnett Type: enhancement | Status: reviewed_ok Priority: major | Milestone: Component: SimFactory | Version: Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):
* status: review => reviewed_ok
#1013: Don't log in multiple times for sim sync --------------------------+------------------------------------------------- Reporter: eschnett | Owner: eschnett Type: enhancement | Status: closed Priority: major | Milestone: Component: SimFactory | Version: Resolution: fixed | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Applied in r1755.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit