#1011: Dependencies ignore compiler flags ----------------------+----------------------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: new Priority: major | Milestone: Component: Cactus | Version: Keywords: | ----------------------+----------------------------------------------------- The dependency calculation ignores compiler flags. For example, when a compiler flag is used that enables the AVX instructions, then this defines the preprocessor macro __AVX__. When dependencies are calculated, this macro is not defined, which means that a different set of include files is used.
I believe that CFLAGS or CXXFLAGS need to be used when the dependencies are calculated.
#1011: Dependencies ignore compiler flags -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: review Priority: major | Milestone: Component: Cactus | Version: Resolution: | Keywords: -----------------------+---------------------------------------------------- Changes (by eschnett):
* status: new => review
Comment:
I propose the attached modification to determining dependencies. Essentially, every time $(CC) or $(CXX) is used, $(CFLAGS) or $(CXXFLAGS) are added in addition to $(CPPFLAGS).
This seems to work fine on all systems I tested, but of course I cannot tell whether it corrects the respective problem on all these systems. It does correct the system on Mac OS X.
After applying this patch, autoconf needs to run, and force-reconfigure needs to be modified.
#1011: Dependencies ignore compiler flags -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: review Priority: major | Milestone: Component: Cactus | Version: Resolution: | Keywords: -----------------------+----------------------------------------------------
Comment (by rhaas):
Please apply.
#1011: Dependencies ignore compiler flags -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: reviewed_ok Priority: major | Milestone: Component: Cactus | Version: Resolution: | Keywords: -----------------------+---------------------------------------------------- Changes (by eschnett):
* status: review => reviewed_ok
#1011: Dependencies ignore compiler flags -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: closed Priority: major | Milestone: Component: Cactus | Version: Resolution: fixed | Keywords: -----------------------+---------------------------------------------------- Changes (by eschnett):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Applied in r4859.
trac@lists.einsteintoolkit.org