#1139: Adding PeriodicCarpet to the Einstein Toolkit -------------------------+-------------------------------------------------- Reporter: bentivegna | Owner: eschnett Type: enhancement | Status: new Priority: minor | Milestone: Component: Carpet | Version: development version Keywords: | -------------------------+-------------------------------------------------- Old thorn Periodic does not behave correctly with AMR patches that overlap the periodic boundaries (see ticket #694). A significantly different mechanism to handle has been implemented, by Erik, in LSUThorns/PeriodicCarpet. This thorn should be added to the Einstein Toolkit, and slowly replace Periodic.
Before introducing this thorn to the ET, we need at least one testcase with AMR.
#1139: Adding PeriodicCarpet to the Einstein Toolkit --------------------------+------------------------------------------------- Reporter: bentivegna | Owner: eschnett Type: enhancement | Status: new Priority: minor | Milestone: Component: Carpet | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by rhaas):
Really replace? Will it work with PUGH (required at least for test cases if not for much else anymore).
#1139: Adding PeriodicCarpet to the Einstein Toolkit --------------------------+------------------------------------------------- Reporter: bentivegna | Owner: eschnett Type: enhancement | Status: review Priority: minor | Milestone: Component: Carpet | Version: development version Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):
* status: new => review
#1139: Adding PeriodicCarpet to the Einstein Toolkit --------------------------+------------------------------------------------- Reporter: bentivegna | Owner: eschnett Type: enhancement | Status: review Priority: minor | Milestone: Component: Carpet | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by eschnett):
This thorn is specific to Carpet, as the name indicates. PUGH provides built-in periodic boundaries and doesn't need an external thorn.
I believe the thorn is ready to be included except for the lack of documentation.
#1139: Adding PeriodicCarpet to the Einstein Toolkit --------------------------+------------------------------------------------- Reporter: bentivegna | Owner: eschnett Type: enhancement | Status: review Priority: minor | Milestone: Component: Carpet | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by bentivegna):
And the lack of a test with AMR that proves that the thorn succeeds where Periodic fails. I'm working on this now.
#1139: Adding PeriodicCarpet to the Einstein Toolkit --------------------------+------------------------------------------------- Reporter: bentivegna | Owner: eschnett Type: enhancement | Status: review Priority: minor | Milestone: Component: Carpet | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by bentivegna):
I've now committed an AMR test and some documentation. Please take a look and see if anything can be added or improved.
#1139: Adding PeriodicCarpet to the Einstein Toolkit --------------------------+------------------------------------------------- Reporter: bentivegna | Owner: eschnett Type: enhancement | Status: review Priority: minor | Milestone: Component: Carpet | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by eschnett):
I think the thorn is ready now; I'd like an independent review.
#1139: Adding PeriodicCarpet to the Einstein Toolkit --------------------------+------------------------------------------------- Reporter: bentivegna | Owner: eschnett Type: enhancement | Status: review Priority: minor | Milestone: Component: Carpet | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by knarf):
After a quick glance - Please mention in "param.ccl: peridic" that this enables all directions (in particular that you don't need this if you set (some of) periodic_[xyz]). Alternatively, the parameter could be named periodic_xyz. - Please document that none of these parameters can be used to turn periodic boundary conditions off. In particular, 'periodic = yes; periodic_z = no' wouldn't do what you might expect.
#1139: Adding PeriodicCarpet to the Einstein Toolkit --------------------------+------------------------------------------------- Reporter: bentivegna | Owner: eschnett Type: enhancement | Status: closed Priority: minor | Milestone: Component: Carpet | Version: development version Resolution: fixed | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):
* status: review => closed * resolution: => fixed
Comment:
Done.
Added in revision 208.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit