#682: LSUThorns/Vectors: Simplify API for partial vector stores -------------------------+-------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: new Priority: major | Milestone: Component: Other | Version: Keywords: | -------------------------+-------------------------------------------------- Implement vec_store_nta_partial, which offers a simpler interface, similar to the one used in OpenCL.
#682: LSUThorns/Vectors: Simplify API for partial vector stores ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: new => review * component: Other => EinsteinToolkit thorn
#682: LSUThorns/Vectors: Simplify API for partial vector stores ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by barry.wardell):
It looks like you have two "else if (v8stp_lo)" in the SSE4A part of the patch. Should the second of these be "else if (v8stp_hi)"? If so,would the tests have picked this up on an SSE4A machine? If so, and the AVX code also pases the test, I think this should be applied. I'd also recommend adding a pseudo-code comment explaining what the AVX version does.
#682: LSUThorns/Vectors: Simplify API for partial vector stores ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: review => closed * resolution: => fixed
Comment:
Applied.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit