#1866: do not compress pdf files stored in Cactus repo ---------------------------+------------------------------------------------ Reporter: rhaas | Owner: Type: enhancement | Status: new Priority: optional | Milestone: Component: Cactus | Version: development version Keywords: documentatino | ---------------------------+------------------------------------------------ Compressing the pdf files means that changes propagate through the file and a change at the beginning of the file cause changes in all of the compressed file, effectively disabling git's delta compression of blobs.
The patch proposed in https://bitbucket.org/cactuscode/cactus/pull- requests/23/cactus-disable-compression-in-included-pdf/diff disables pdf compression
#1866: do not compress pdf files stored in Cactus repo --------------------------+------------------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: optional | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: documentatino --------------------------+------------------------------------------------- Changes (by rhaas):
* status: new => review
#1866: do not compress pdf files stored in Cactus repo --------------------------+------------------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: optional | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: documentatino --------------------------+-------------------------------------------------
Comment (by hinder):
What is the compression ratio?
#1866: do not compress pdf files stored in Cactus repo --------------------------+------------------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: reviewed_ok Priority: optional | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: documentatino --------------------------+------------------------------------------------- Changes (by knarf):
* status: review => reviewed_ok
Comment:
For the UsersGuide I get about 40% of the uncompressed size. Given that rather poor compression we wouldn't loose a lot by using the uncompressed ones.
#1866: do not compress pdf files stored in Cactus repo --------------------------+------------------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: reviewed_ok Priority: optional | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: documentatino --------------------------+-------------------------------------------------
Comment (by barry.wardell):
Also keep in mind that git compresses repository data so it's possible that you could actually end up being more space-efficient by not pre- compressing files.
#1866: do not compress pdf files stored in Cactus repo --------------------------+------------------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: reviewed_ok Priority: optional | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: documentatino --------------------------+-------------------------------------------------
Comment (by knarf):
Yes - That is what the ticket is about. You loose space because the files on-disk would be uncompressed, but you probably gain more because all the history would be smaller using uncompressed files. And since git stores all history and not just the last version that can add up.
#1866: do not compress pdf files stored in Cactus repo --------------------------+------------------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: closed Priority: optional | Milestone: Component: Cactus | Version: development version Resolution: fixed | Keywords: documentatino --------------------------+------------------------------------------------- Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Applied in git hash 8e94053 of the flesh.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit