[Einstein Toolkit] #1631: The dgfe branch for McLachlan generates NaNs

List overview All Threads
Download

newer

older

[Einstein Toolkit] #1866: do not...

[Einstein Toolkit] #1871: Error...

Einstein Toolkit

15 Jun 2014 15 Jun '14

4:02 p.m.

#1631: The dgfe branch for McLachlan generates NaNs -----------------------------------------------------------+---------------- Reporter: Jonah Miller <jonah.maxwell.miller@…> | Owner: eschnett Type: defect | Status: new Priority: optional | Milestone: ET_2014_11 Component: EinsteinToolkit thorn | Version: development version Keywords: dgfe,mclachlan,gamma driver | -----------------------------------------------------------+---------------- When one uses the gamma driver formulation in the dgfe branch of McLachlan and sets the shiftGammaCoefficient to zero, the runtime output has NaNs because the code divides by zero.

A bit of flow control fixes this. Attached is a patch for the branch.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1631 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Show replies by date

Einstein Toolkit

15 Jun 15 Jun

4:50 p.m.

#1631: The dgfe branch for McLachlan generates NaNs ------------------------------------------------------------+--------------- Reporter: Jonah Miller <jonah.maxwell.miller@…> | Owner: eschnett Type: defect | Status: review Priority: optional | Milestone: ET_2014_11 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: dgfe,mclachlan,gamma driver ------------------------------------------------------------+--------------- Changes (by eschnett):

* status: new => review

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1631#comment:1 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

16 Jun 16 Jun

9:34 a.m.

#1631: The dgfe branch for McLachlan generates NaNs ------------------------------------------------------------+--------------- Reporter: Jonah Miller <jonah.maxwell.miller@…> | Owner: eschnett Type: defect | Status: reviewed_ok Priority: optional | Milestone: ET_2014_11 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: dgfe,mclachlan,gamma driver ------------------------------------------------------------+--------------- Changes (by knarf):

* status: review => reviewed_ok

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1631#comment:2 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

5:02 p.m.

#1631: The dgfe branch for McLachlan generates NaNs ------------------------------------------------------------+--------------- Reporter: Jonah Miller <jonah.maxwell.miller@…> | Owner: eschnett Type: defect | Status: reviewed_ok Priority: optional | Milestone: ET_2014_11 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: dgfe,mclachlan,gamma driver ------------------------------------------------------------+---------------

Comment (by eschnett):

The same problem also exists on the rewrite branch, and the same solution should be applied there.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1631#comment:3 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

5:20 p.m.

#1631: The dgfe branch for McLachlan generates NaNs ------------------------------------------------------------+--------------- Reporter: Jonah Miller <jonah.maxwell.miller@…> | Owner: eschnett Type: defect | Status: reviewed_ok Priority: optional | Milestone: ET_2014_11 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: dgfe,mclachlan,gamma driver ------------------------------------------------------------+---------------

Comment (by Jonah Miller <jonah.maxwell.miller@…>):

If no one else has started working on this, I can go through the rewrite branch and generate another patch. Just let me know.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1631#comment:4 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

5:30 p.m.

#1631: The dgfe branch for McLachlan generates NaNs ------------------------------------------------------------+--------------- Reporter: Jonah Miller <jonah.maxwell.miller@…> | Owner: eschnett Type: defect | Status: reviewed_ok Priority: optional | Milestone: ET_2014_11 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: dgfe,mclachlan,gamma driver ------------------------------------------------------------+---------------

Comment (by diener):

I'm currently working on the compatibility of the rewrite branch with the main branch. In order to reduce the risk of conflicts, please hold off until that is completed.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1631#comment:5 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

5:57 p.m.

#1631: The dgfe branch for McLachlan generates NaNs ------------------------------------------------------------+--------------- Reporter: Jonah Miller <jonah.maxwell.miller@…> | Owner: eschnett Type: defect | Status: reviewed_ok Priority: optional | Milestone: ET_2014_11 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: dgfe,mclachlan,gamma driver ------------------------------------------------------------+---------------

Comment (by Jonah Miller <jonah.maxwell.miller@…>):

Okay, thanks. I'll keep an eye out for the commit to the main branch.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1631#comment:6 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

18 Jun 18 Jun

1:04 p.m.

#1631: The dgfe branch for McLachlan generates NaNs ------------------------------------------------------------+--------------- Reporter: Jonah Miller <jonah.maxwell.miller@…> | Owner: eschnett Type: defect | Status: reviewed_ok Priority: optional | Milestone: ET_2014_11 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: dgfe,mclachlan,gamma driver ------------------------------------------------------------+---------------

Comment (by diener):

This patch doesn't work when applied to the rewrite branch. This is due to vector instructions being used and so the variable shiftGammaCoeffValue is declared as a CCTK_REAL_VEC. Comparing this to a scalar value does not work. The easy fix is to replace shiftGammaCoeffValue with the scalar parameter shiftGammaCoeff. The expression for shiftGammaCoeffValue guarantees that it is zero if shiftGammaCoeff is.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1631#comment:7 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

20 Oct 20 Oct

10:51 a.m.

#1631: The dgfe branch for McLachlan generates NaNs ------------------------------------------------------------+--------------- Reporter: Jonah Miller <jonah.maxwell.miller@…> | Owner: eschnett Type: defect | Status: reviewed_ok Priority: optional | Milestone: ET_2014_11 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: dgfe,mclachlan,gamma driver ------------------------------------------------------------+---------------

Comment (by hinder):

Please apply.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1631#comment:8 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

10 Nov 10 Nov

9:13 a.m.

#1631: The dgfe branch for McLachlan generates NaNs ------------------------------------------------------------+--------------- Reporter: Jonah Miller <jonah.maxwell.miller@…> | Owner: eschnett Type: defect | Status: reviewed_ok Priority: optional | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: dgfe,mclachlan,gamma driver ------------------------------------------------------------+--------------- Changes (by knarf):

* milestone: ET_2014_11 =>

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1631#comment:9 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

11 Apr 11 Apr

7:40 a.m.

#1631: The dgfe branch for McLachlan generates NaNs ------------------------------------------------------------+--------------- Reporter: Jonah Miller <jonah.maxwell.miller@…> | Owner: eschnett Type: defect | Status: reviewed_ok Priority: optional | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: dgfe,mclachlan,gamma driver ------------------------------------------------------------+---------------

Comment (by rhaas):

Has there been progress on this? It is still set to "reviewed" and unless the patch actually applies I believe it should be reset to "confirmed" until a new patch is provided.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1631#comment:10 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

17 Apr 17 Apr

6:36 a.m.

#1631: The dgfe branch for McLachlan generates NaNs ------------------------------------------------------------+--------------- Reporter: Jonah Miller <jonah.maxwell.miller@…> | Owner: eschnett Type: defect | Status: reopened Priority: optional | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: dgfe,mclachlan,gamma driver ------------------------------------------------------------+--------------- Changes (by rhaas):

* status: reviewed_ok => reopened

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1631#comment:11 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

3827

Age (days ago)

4499

Last active (days ago)

trac@lists.einsteintoolkit.org

11 comments

1 participants

tags (0)

participants (1)

Einstein Toolkit