[Einstein Toolkit] #565: ADMBase: Change default value of initial_shift parameter to "zero"
#565: ADMBase: Change default value of initial_shift parameter to "zero" -----------------------------------+---------------------------------------- Reporter: bmundim | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: | -----------------------------------+---------------------------------------- Currently the default value of initial_shift is "none". GRHydro doesn't support shift_state = 0 anymore for example, and I believe most of the codes do need storage for the shift vector. So I was wondering if it wouldn't be better to change the default for the initial_shift parameter from "none" to "zero". Any opinions about it?
#565: ADMBase: Change default value of initial_shift parameter to "zero" ------------------------------------+--------------------------------------- Reporter: bmundim | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by hinder):
I think this would avoid a lot of problems for beginner (and not so beginner!) users and mysterious segfaults. Any codes which don't need a shift probably don't care much about the additional memory that this change would cause to be wasted.
#565: ADMBase: Change default value of initial_shift parameter to "zero" ------------------------------------+--------------------------------------- Reporter: bmundim | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by bmundim):
If nobody opposes, I would like to change this later today.
Thanks.
#565: ADMBase: Change default value of initial_shift parameter to "zero" ------------------------------------+--------------------------------------- Reporter: bmundim | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: ------------------------------------+--------------------------------------- Changes (by bmundim):
* status: new => closed * resolution: => fixed
Comment:
Change commited.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit