[Einstein Toolkit] #1252: Thorn configuration scripts should not be run if there are missing thorns

List overview All Threads
Download

newer

older

[Einstein Toolkit] #1754:...

[Einstein Toolkit] #1712: Return...

Einstein Toolkit

8 Feb 2013 8 Feb '13

3:10 p.m.

#1252: Thorn configuration scripts should not be run if there are missing thorns -------------------------+-------------------------------------------------- Reporter: hinder | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: Cactus | Version: Keywords: | -------------------------+-------------------------------------------------- If there are thorns present in the thornlist which are not present in the source tree, Cactus currently displays the corresponding error message, and then runs the rest of the CST including thorn configuration scripts. Since these can build large external libraries (e.g. LORENE), it can be a long time before the user notices that the build has failed. I would prefer if Cactus aborted before running the CST scripts.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1252 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Show replies by date

Einstein Toolkit

10 Nov 10 Nov

10 a.m.

#1252: Thorn configuration scripts should not be run if there are missing thorns --------------------------+------------------------------------------------- Reporter: hinder | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: postrelease --------------------------+------------------------------------------------- Changes (by knarf):

* keywords: => postrelease

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1252#comment:1 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

24 Nov 24 Nov

10:23 a.m.

#1252: Thorn configuration scripts should not be run if there are missing thorns --------------------------+------------------------------------------------- Reporter: hinder | Owner: knarf Type: enhancement | Status: assigned Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: postrelease --------------------------+------------------------------------------------- Changes (by anonymous):

* owner: => knarf * status: new => assigned

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1252#comment:2 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

25 Nov 25 Nov

12:39 p.m.

#1252: Thorn configuration scripts should not be run if there are missing thorns --------------------------+------------------------------------------------- Reporter: hinder | Owner: knarf Type: enhancement | Status: assigned Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: postrelease --------------------------+-------------------------------------------------

Comment (by eschnett):

See https://trac.einsteintoolkit.org/ticket/1707.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1252#comment:3 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

30 Nov 30 Nov

4:22 p.m.

#1252: Thorn configuration scripts should not be run if there are missing thorns --------------------------+------------------------------------------------- Reporter: hinder | Owner: knarf Type: enhancement | Status: review Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: postrelease --------------------------+------------------------------------------------- Changes (by knarf):

* status: assigned => review

Comment:

https://bitbucket.org/cactuscode/cactus/branch/early_CST_abort

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1252#comment:4 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

1 Dec 1 Dec

12:11 a.m.

#1252: Thorn configuration scripts should not be run if there are missing thorns --------------------------+------------------------------------------------- Reporter: hinder | Owner: knarf Type: enhancement | Status: review Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: postrelease --------------------------+-------------------------------------------------

Comment (by rhaas):

Erik is working on making the ExternalLibraries build themselves at the same time as the other thorns in ticket 1707 which is also up for review (the branch https://svn.cactuscode.org/projects/ExternalLibraries/GSL/branches/eschnett /delayed-build seems to have stabilized, at least there were no changes over the weekend).

Are those two approaches both applicable (ie does this patch still make sense assuming that all ExternelLibraries would soon do what GSL is trying to do in Erik's branch)?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1252#comment:5 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

9 a.m.

#1252: Thorn configuration scripts should not be run if there are missing thorns --------------------------+------------------------------------------------- Reporter: hinder | Owner: knarf Type: enhancement | Status: review Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: postrelease --------------------------+-------------------------------------------------

Comment (by knarf):

Assuming all external libraries are changed (even outside the ET) I don't see the immediate need for this change anymore, true. The only harm I can see, on the other hand, is that Cactus would bail out before it detected all possible errors - but then if it already got errors in that stage, the likelihood that following errors are simply caused by the earlier ones is high.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1252#comment:6 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

8 Dec 8 Dec

11:20 a.m.

#1252: Thorn configuration scripts should not be run if there are missing thorns --------------------------+------------------------------------------------- Reporter: hinder | Owner: somebody Type: enhancement | Status: assigned Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: postrelease --------------------------+------------------------------------------------- Changes (by knarf):

* owner: knarf => somebody * status: review => assigned

Comment:

testing assignment emails

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1252#comment:7 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

11:20 a.m.

#1252: Thorn configuration scripts should not be run if there are missing thorns --------------------------+------------------------------------------------- Reporter: hinder | Owner: knarf Type: enhancement | Status: assigned Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: postrelease --------------------------+------------------------------------------------- Changes (by knarf):

* owner: somebody => knarf

Comment:

testing assignment emails

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1252#comment:8 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

11:27 a.m.

#1252: Thorn configuration scripts should not be run if there are missing thorns --------------------------+------------------------------------------------- Reporter: hinder | Owner: somebody Type: enhancement | Status: assigned Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: postrelease --------------------------+------------------------------------------------- Changes (by knarf):

* owner: knarf => somebody

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1252#comment:9 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

11:27 a.m.

#1252: Thorn configuration scripts should not be run if there are missing thorns --------------------------+------------------------------------------------- Reporter: hinder | Owner: knarf Type: enhancement | Status: assigned Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: postrelease --------------------------+------------------------------------------------- Changes (by knarf):

* owner: somebody => knarf

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1252#comment:10 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

11:48 a.m.

#1252: Thorn configuration scripts should not be run if there are missing thorns --------------------------+------------------------------------------------- Reporter: hinder | Owner: somebody Type: enhancement | Status: assigned Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: postrelease --------------------------+------------------------------------------------- Changes (by knarf):

* owner: knarf => somebody

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1252#comment:11 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

11:49 a.m.

#1252: Thorn configuration scripts should not be run if there are missing thorns --------------------------+------------------------------------------------- Reporter: hinder | Owner: knarf Type: enhancement | Status: assigned Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: postrelease --------------------------+------------------------------------------------- Changes (by knarf):

* owner: somebody => knarf

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1252#comment:12 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

1:50 p.m.

#1252: Thorn configuration scripts should not be run if there are missing thorns --------------------------+------------------------------------------------- Reporter: hinder | Owner: Type: enhancement | Status: assigned Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: postrelease --------------------------+------------------------------------------------- Changes (by knarf):

* owner: knarf =>

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1252#comment:13 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

9 Jun 9 Jun

6:45 a.m.

#1252: Thorn configuration scripts should not be run if there are missing thorns --------------------------+------------------------------------------------- Reporter: hinder | Owner: Type: enhancement | Status: assigned Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: postrelease --------------------------+-------------------------------------------------

Comment (by rhaas):

Can this be closed (see comment:6) due to the changes to ExternalLibraries separationg detection from building?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1252#comment:14 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

7:20 a.m.

#1252: Thorn configuration scripts should not be run if there are missing thorns --------------------------+------------------------------------------------- Reporter: hinder | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: Component: Cactus | Version: Resolution: fixed | Keywords: postrelease --------------------------+------------------------------------------------- Changes (by hinder):

* status: assigned => closed * resolution: => fixed

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1252#comment:15 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

9:20 a.m.

#1252: Thorn configuration scripts should not be run if there are missing thorns --------------------------+------------------------------------------------- Reporter: hinder | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: Component: Cactus | Version: Resolution: fixed | Keywords: postrelease --------------------------+-------------------------------------------------

Comment (by knarf):

Yes. Just for the record: the CST aborts early in this case now. I just couldn't find this ticket when I merged the pull request a while back.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1252#comment:16 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

4140

Age (days ago)

4991

Last active (days ago)

trac@lists.einsteintoolkit.org

16 comments

1 participants

tags (0)

participants (1)

Einstein Toolkit