#1712: Return snprintf.c ----------------------+----------------------------------------------------- Reporter: eschnett | Owner: Type: task | Status: new Priority: minor | Milestone: Component: Other | Version: development version Keywords: | ----------------------+----------------------------------------------------- C99 provides snprintf, and we assume at least C99 support in Cactus. Cactus does not need to provide snprintf any more.
#1712: Retire snprintf.c -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: Type: task | Status: new Priority: minor | Milestone: Component: Other | Version: development version Resolution: | Keywords: -----------------------+----------------------------------------------------
#1712: Retire snprintf.c -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: Type: task | Status: new Priority: minor | Milestone: Component: Other | Version: development version Resolution: | Keywords: -----------------------+----------------------------------------------------
Comment (by knarf):
"approved" as being ok on the ET call today.
#1712: Retire snprintf.c -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: Type: task | Status: closed Priority: minor | Milestone: Component: Other | Version: development version Resolution: fixed | Keywords: -----------------------+---------------------------------------------------- Changes (by eschnett):
* status: new => closed * resolution: => fixed
Comment:
Done.
#1712: Retire snprintf.c -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: Type: task | Status: reopened Priority: minor | Milestone: Component: Other | Version: development version Resolution: | Keywords: -----------------------+---------------------------------------------------- Changes (by rhaas):
* status: closed => reopened * resolution: fixed =>
Comment:
When retiring snprintf, the related function strdup was also retired. However strdup is not in C99 but in BSD/POSIX and thus is not available by default. In C it is implicitly declared to return int which fails if the actual returned pointer is larger than 32 bits. The branch
https://bitbucket.org/cactuscode/cactus/branch/rhaas%2Fcheck-for-PI-and- strdup
provides configure checks for this routine.
#1712: Retire snprintf.c -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: Type: task | Status: review Priority: minor | Milestone: Component: Other | Version: development version Resolution: | Keywords: -----------------------+---------------------------------------------------- Changes (by rhaas):
* status: reopened => review
#1712: Retire snprintf.c -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: Type: task | Status: review Priority: minor | Milestone: Component: Other | Version: development version Resolution: | Keywords: -----------------------+----------------------------------------------------
Comment (by eschnett):
Regarding {{{strdup}}}: Ouch. Hello 1972, nice to meet you.
Isn't there a gcc warning that requires prototypes for all functions? I think we should be able to enable this safely.
#1712: Retire snprintf.c -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: Type: task | Status: review Priority: minor | Milestone: Component: Other | Version: development version Resolution: | Keywords: -----------------------+----------------------------------------------------
Comment (by rhaas):
There is a gcc warning that one can use for prototypes, however it warns about many benign uses of say {{{printf}}} without prototype. It is also only a warning and I would not want to have to rely on it (or only on its error-ized version from -Werror) to prevent subtle errors (since the wrong prototyped one will work as long as the returned address is less than 2GB) since we have very many other warnings that are triggered when compiling the full set of thorns.
#1712: Retire snprintf.c -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: Type: task | Status: review Priority: minor | Milestone: Component: Other | Version: development version Resolution: | Keywords: -----------------------+----------------------------------------------------
Comment (by rhaas):
Anyone care to review this?
#1712: Retire snprintf.c -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: Type: task | Status: reviewed_ok Priority: minor | Milestone: Component: Other | Version: development version Resolution: | Keywords: -----------------------+---------------------------------------------------- Changes (by eschnett):
* status: review => reviewed_ok
#1712: Retire snprintf.c -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: Type: task | Status: closed Priority: minor | Milestone: Component: Other | Version: development version Resolution: fixed | Keywords: -----------------------+---------------------------------------------------- Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Applied in git hash 898d23d08a833aa9ebb6c9690765aaa4d6afc436 of the flesh.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit