#2125: LORENE2: Improve generation of BNS ID for larger mass ratio ---------------------------------------+------------------------------------ Reporter: roberto.depietri@… | Owner: depietri Type: enhancement | Status: new Priority: optional | Milestone: ET_2018_08 Component: EinsteinToolkit thorn | Version: development version Keywords: LORENE2 | ---------------------------------------+------------------------------------
#2125: LORENE2: Improve generation of BNS ID for larger mass ratio ----------------------------------------+----------------------------------- Reporter: roberto.depietri@… | Owner: depietri Type: enhancement | Status: review Priority: optional | Milestone: ET_2018_08 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: LORENE2 ----------------------------------------+----------------------------------- Changes (by rhaas):
* status: new => review
#2125: LORENE2: Improve generation of BNS ID for larger mass ratio ----------------------------------------+----------------------------------- Reporter: roberto.depietri@… | Owner: depietri Type: enhancement | Status: review Priority: optional | Milestone: ET_2018_08 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: LORENE2 ----------------------------------------+-----------------------------------
Comment (by rhaas):
Hello Roberto, I am somewhat confused why you created a ticket since you have already applied a change to master? Looking at the commit https://bitbucket.org/einsteintoolkit/lorene/commits/d80424982ae8/ this seems to add a line that should have already been in https://bitbucket.org/einsteintoolkit/lorene/commits/b1ea81103c2549d0097deaf... since otherwise the former is a no-op :-).
The commit unfortunately has a bad commit message which it does not tell me what the commit does, please do use descriptive commit messages and do not assume that ticket numbers or (any) urls are useful. Those are often not very helpful, since eg the ticketing system may go away much sooner than the interest in the commits.
No big deal right now but it shows why we ask for at least some cursory review to catch glitches like this.
Would you like me to just close this ticket again or is there more to come?
#2125: LORENE2: Improve generation of BNS ID for larger mass ratio ----------------------------------------+----------------------------------- Reporter: roberto.depietri@… | Owner: depietri Type: enhancement | Status: review Priority: optional | Milestone: ET_2018_08 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: LORENE2 ----------------------------------------+-----------------------------------
Comment (by anonymous):
Unfortunately there was a small bug in the way patch where applied. This is the reason for the last commit. Still doing some test with multiple compilations.
#2125: LORENE2: Improve generation of BNS ID for larger mass ratio ----------------------------------------+----------------------------------- Reporter: roberto.depietri@… | Owner: depietri Type: enhancement | Status: review Priority: optional | Milestone: ET_2018_08 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: LORENE2 ----------------------------------------+-----------------------------------
Comment (by sbrandt):
Are there any updates on this ticket?
#2125: LORENE2: Improve generation of BNS ID for larger mass ratio ----------------------------------------+----------------------------------- Reporter: roberto.depietri@… | Owner: depietri Type: enhancement | Status: closed Priority: optional | Milestone: ET_2018_08 Component: EinsteinToolkit thorn | Version: development version Resolution: fixed | Keywords: LORENE2 ----------------------------------------+----------------------------------- Changes (by sbrandt):
* status: review => closed * resolution: => fixed
trac@lists.einsteintoolkit.org
-
Einstein Toolkit