#2128: Hydro_RNSID should not inherit from GRHydro --------------------------------+------------------------------------------- Reporter: zachetie@… | Owner: Type: defect | Status: new Priority: unset | Milestone: Component: Other | Version: development version Keywords: | --------------------------------+------------------------------------------- Hydro_RNSID will not compile without GRHydro, as apparently it inherits some variable(s) from GRHydro. Being a hydro initial data thorn, it should only depend on HydroBase & ADMBase.
#2128: Hydro_RNSID should not inherit from GRHydro ---------------------------------+------------------------------------------ Reporter: zachetie@… | Owner: Type: defect | Status: confirmed Priority: unset | Milestone: Component: Other | Version: development version Resolution: | Keywords: Hydro_RNSID ---------------------------------+------------------------------------------ Changes (by rhaas):
* keywords: => Hydro_RNSID * status: new => confirmed
#2128: Hydro_RNSID should not inherit from GRHydro ---------------------------------+------------------------------------------ Reporter: zachetie@… | Owner: Type: defect | Status: confirmed Priority: unset | Milestone: Component: Other | Version: development version Resolution: | Keywords: Hydro_RNSID ---------------------------------+------------------------------------------
Comment (by rhaas):
Pull request which removes GRHydro dependency is here: https://bitbucket.org/einsteintoolkit/einsteininitialdata/pull-requests/4 /hydro_rnsid-remove-dependency-on-grhydro/diff
This so far is untested and while in principle there should be no change in data since GRHydro alsready schedules an InitialPrim2Con routine there may be differences in the atmosphere treatment and / or for past timelevels.
#2128: Hydro_RNSID should not inherit from GRHydro ---------------------------------+------------------------------------------ Reporter: zachetie@… | Owner: Type: defect | Status: confirmed Priority: major | Milestone: Component: Other | Version: development version Resolution: | Keywords: Hydro_RNSID ---------------------------------+------------------------------------------ Changes (by rhaas):
* priority: unset => major
#2128: Hydro_RNSID should not inherit from GRHydro ---------------------------------+------------------------------------------ Reporter: zachetie@… | Owner: Type: defect | Status: review Priority: major | Milestone: Component: Other | Version: development version Resolution: | Keywords: Hydro_RNSID ---------------------------------+------------------------------------------ Changes (by rhaas):
* status: confirmed => review
trac@lists.einsteintoolkit.org
-
Einstein Toolkit