#547: WALLTIME_HOURS incorrect ------------------------+--------------------------------------------------- Reporter: hinder | Owner: eschnett Type: defect | Status: new Priority: major | Milestone: Component: SimFactory | Version: Keywords: | ------------------------+--------------------------------------------------- The SimFactory variable WALLTIME_HOURS should be expanded to the walltime of the job, not the walltime which was requested on the command line. If the user specifies more walltime than the queue allows, SimFactory splits the job into several restarts to give the total walltime requested. However, parameter files expect WALLTIME_HOURS to be the walltime of the job, not of the simulation.
#547: WALLTIME_HOURS incorrect -------------------------+-------------------------------------------------- Reporter: hinder | Owner: eschnett Type: defect | Status: review Priority: major | Milestone: Component: SimFactory | Version: Resolution: | Keywords: -------------------------+-------------------------------------------------- Changes (by rhaas):
* status: new => review
Comment:
This still happens, it renders simfactory's facility to automatically split a long run into a set of shorter chained runs useless. The attached patch fixes the incorrect walltime issue, not sure what other side effects it has.
#547: WALLTIME_HOURS incorrect -------------------------+-------------------------------------------------- Reporter: hinder | Owner: eschnett Type: defect | Status: review Priority: major | Milestone: Component: SimFactory | Version: Resolution: | Keywords: -------------------------+--------------------------------------------------
Comment (by eschnett):
This patch seems correct. (The overall presubmission logic is a bit dodgy, though.) Please apply.
#547: WALLTIME_HOURS incorrect -------------------------+-------------------------------------------------- Reporter: hinder | Owner: eschnett Type: defect | Status: closed Priority: major | Milestone: Component: SimFactory | Version: Resolution: fixed | Keywords: -------------------------+-------------------------------------------------- Changes (by rhaas):
* status: review => closed * resolution: => fixed
Comment:
Applied. Surprised to have commit rights for once :-)
trac@lists.einsteintoolkit.org
-
Einstein Toolkit