#795: Carpet dev fails to compile without OpenMP --------------------+------------------------------------------------------- Reporter: tbode | Owner: eschnett Type: defect | Status: new Priority: minor | Milestone: Component: Carpet | Version: development version Keywords: | --------------------+------------------------------------------------------- Compilation errors out in SetupGH.cc on line 359 due to the call to omp_get_thread_num() function without OpenMP.
#795: Carpet dev fails to compile without OpenMP ---------------------+------------------------------------------------------ Reporter: tbode | Owner: eschnett Type: defect | Status: new Priority: minor | Milestone: Component: Carpet | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------
Comment (by rhaas):
Attached please find my current best guess for a fix. They _should_ work but I am still testing them, and after the last two try-and-revert cycles I wanted to be a bit cautious.
#795: Carpet dev fails to compile without OpenMP ---------------------+------------------------------------------------------ Reporter: tbode | Owner: eschnett Type: defect | Status: new Priority: minor | Milestone: Component: Carpet | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------
Comment (by eschnett):
This patch is fine (if it builds and works).
An alternative implementation would be an #ifdef _OPENMP around the call to set the CPU affinity, and replacing the thread number with 0 in the #else branch.
#795: Carpet dev fails to compile without OpenMP ---------------------+------------------------------------------------------ Reporter: tbode | Owner: eschnett Type: defect | Status: closed Priority: minor | Milestone: Component: Carpet | Version: development version Resolution: fixed | Keywords: ---------------------+------------------------------------------------------ Changes (by rhaas):
* status: new => closed * resolution: => fixed
Comment:
applied the patches.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit