#2120: check that all parfiles that set ADMMacros::spatial_order also set GRHydro::sources_spatial_order to the same value -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: task | Status: new Priority: minor | Milestone: ET_2018_02 Component: EinsteinToolkit thorn | Version: development version Keywords: GRHydro | -----------------------------------+---------------------------------------- Since GRHydro switched from ADMMacros to its own finite differencing for the Christoffels in the source term, we must make sure that the change was propagated to all parfiles. We may even want to check in GRHydro's paramcheck that, if ADMMacros is active its {{{spatial_order}}} parameter agrees with GRHydro's {{{sources_spatial_order}}} which should capture all legacy parfiles that need updating.
#2120: check that all parfiles that set ADMMacros::spatial_order also set GRHydro::sources_spatial_order to the same value ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: task | Status: review Priority: minor | Milestone: ET_2018_02 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: GRHydro ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: new => review
Comment:
Turns out I had written such code in 2016-06 but apparently never pushed it. This is not in a pull request:
https://bitbucket.org/einsteintoolkit/einsteinevolve/pull-requests/11 /grhydro-add-check-when-admmacros/diff
#2120: check that all parfiles that set ADMMacros::spatial_order also set GRHydro::sources_spatial_order to the same value ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: task | Status: review Priority: minor | Milestone: ET_2018_02 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: GRHydro ------------------------------------+---------------------------------------
Comment (by rhaas):
To be included only after the release. Testing of course that all parfiles are correct should happen before the release.
trac@lists.einsteintoolkit.org