#2118: Neutron star gallery example produces output different from what is shown on website in ET_Tesla ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: new Priority: major | Milestone: ET_2018_02 Component: Other | Version: development version Resolution: | Keywords: Gallery GRHydro ---------------------+------------------------------------------------------ Changes (by rhaas):

* milestone: => ET_2018_02

#2118: Neutron star gallery example produces output different from what is shown on website in ET_Tesla ----------------------+----------------------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: blocker | Milestone: ET_2018_02 Component: Other | Version: development version Resolution: | Keywords: Gallery GRHydro ----------------------+----------------------------------------------------- Changes (by hinder):

* priority: major => blocker

#2118: Neutron star gallery example produces output different from what is shown on website in ET_Tesla ----------------------+----------------------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: confirmed Priority: blocker | Milestone: ET_2018_02 Component: Other | Version: development version Resolution: | Keywords: Gallery GRHydro regression ----------------------+----------------------------------------------------- Description changed by hinder:

Old description:

The gallery example https://einsteintoolkit.org/gallery/ns/index.html produces output significantly different from what is shown in the gallery. Namely the maximum density drops to ~88% of the correct value compared to only ~97% in the plot in the gallery.

Attached please find stdout, data file and the plot.

New description:

The gallery example https://einsteintoolkit.org/gallery/ns/index.html produces output significantly different from what is shown in the gallery. Namely the maximum density drops to ~88% of the correct value compared to only ~97% in the plot in the gallery.

Attached please find stdout, data file and the plot.

||=Release=||=Date=||=''ρ'',,max,,=|| || Gallery || 2013-05 || [[Image(https://einsteintoolkit.org/gallery/ns/rho_max.png, 50%)]] || || PayneGaposhkin || 2016-12 || [[Image(rho-PayneGaposhkin.png, 50%)]] || || Sommerville || 2015-11 || [[Image(rho-Sommerville.png, 50%)]] ||

--

#2118: Neutron star gallery example produces output different from what is shown on website in ET_Tesla ----------------------+----------------------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: confirmed Priority: blocker | Milestone: ET_2018_02 Component: Other | Version: development version Resolution: | Keywords: Gallery GRHydro regression ----------------------+----------------------------------------------------- Description changed by rhaas:

Old description:

The gallery example https://einsteintoolkit.org/gallery/ns/index.html produces output significantly different from what is shown in the gallery. Namely the maximum density drops to ~88% of the correct value compared to only ~97% in the plot in the gallery.

Attached please find stdout, data file and the plot.

||=Release=||=Date=||=''ρ'',,max,,=|| || Gallery || 2013-05 || [[Image(https://einsteintoolkit.org/gallery/ns/rho_max.png, 50%)]] || || Sommerville || 2015-11 || [[Image(rho-Sommerville.png, 50%)]] || || PayneGaposhkin || 2016-12 || [[Image(rho-PayneGaposhkin.png, 50%)]] ||

New description:

The gallery example https://einsteintoolkit.org/gallery/ns/index.html produces output significantly different from what is shown in the gallery. Namely the maximum density drops to ~88% of the correct value compared to only ~97% in the plot in the gallery.

Attached please find stdout, data file and the plot.

||=Release=||=Date=||=''ρ'',,max,,=|| || Gallery || 2013-05 || [[Image(https://einsteintoolkit.org/gallery/ns/rho_max.png, 50%)]] || || Sommerville || 2015-11 || [[Image(rho-Sommerville.png, 50%)]] || || PayneGaposhkin || 2016-12 || [[Image(rho-PayneGaposhkin.png, 50%)]] || || master || 2017-02 || [[Image(rho.png, 50%)]] ||

--

#2118: Neutron star gallery example produces output different from what is shown on website in ET_Tesla ----------------------+----------------------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: confirmed Priority: blocker | Milestone: ET_2018_02 Component: Other | Version: development version Resolution: | Keywords: Gallery GRHydro regression ----------------------+-----------------------------------------------------

Old description:

The gallery example https://einsteintoolkit.org/gallery/ns/index.html produces output significantly different from what is shown in the gallery. Namely the maximum density drops to ~88% of the correct value compared to only ~97% in the plot in the gallery.

Attached please find stdout, data file and the plot.

||=Release=||=Date=||=''ρ'',,max,,=|| || Gallery || 2013-05 || [[Image(https://einsteintoolkit.org/gallery/ns/rho_max.png, 50%)]] || || Gauss|| 2013-05 || [[Image(rho-Gauss.png, 50%)]] || || Sommerville || 2015-11 || [[Image(rho-Sommerville.png, 50%)]] || || PayneGaposhkin || 2016-12 || [[Image(rho-PayneGaposhkin.png, 50%)]] || || master || 2017-02 || [[Image(rho.png, 50%)]] ||

New description:

The gallery example https://einsteintoolkit.org/gallery/ns/index.html produces output significantly different from what is shown in the gallery. Namely the maximum density drops to ~88% of the correct value compared to only ~97% in the plot in the gallery.

Attached please find stdout, data file and the plot.

||=Release=||=Date=||=''ρ'',,max,,=|| || Gallery || 2013-05 || [[Image(https://einsteintoolkit.org/gallery/ns/rho_max.png, 50%)]] || || Gauss || 2013-05 || [[Image(rho-Gauss.png, 50%)]] || || HerschelCXX || 2014-11 || [[Image(rho-HerschelCXX.png, 50%)]] || || Herschel || 2014-11 || [[Image(rho-Herschel.png, 50%)]] || || HilbertF90 || 2015-05 || [[Image(rho-HilbertF90.png, 50%)]] || || Hilbert || 2015-05 || [[Image(rho-Hilbert.png, 50%)]] || || Sommerville || 2015-11 || [[Image(rho-Sommerville.png, 50%)]] || || PayneGaposhkin || 2016-12 || [[Image(rho-PayneGaposhkin.png, 50%)]] || || masterF90 || 2017-02 || [[Image(rho-masterF90.png, 50%)]] || || master || 2017-02 || [[Image(rho.png, 50%)]] ||

--

Comment (by rhaas):

The difference shows up between the Herschel (good) and Hilbert (bad) releases:

|| Herschel || 2014-11 || [[Image(rho-Herschel.png, 50%)]] || || Hilbert || 2015-05 || [[Image(rho-Hilbert.png, 50%)]] ||

which happens to be when the 'default' code in GRHydro switched from F90 (Herschel) to CXX (Hilbert). However flipping the {{{use_cxx_code}}} parameter does not affect the output so that it does not seem to be a difference between CXX and F90 code but something else that changed in between the releases.

#2118: Neutron star gallery example produces output different from what is shown on website in ET_Tesla ----------------------+----------------------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: closed Priority: blocker | Milestone: ET_2018_02 Component: Other | Version: development version Resolution: fixed | Keywords: Gallery GRHydro regression ----------------------+----------------------------------------------------- Changes (by rhaas):

* status: confirmed => closed * resolution: => fixed

Comment:

Yup, that was it, adding "GRHydro::sources_spatial_order = 4" restores the old plot:

[[Image(rho-source_spatial_order4.png, 50%)]]

I have updated the parfile in the gallery.

Lesson for the future:

Though shalt not silently change default behaviour, for backwards

compatibility is a fickle god and will be punishing the maintainers for the sin of the developers to the third and fourth generation of those who hate it.

or so.

#2118: Neutron star gallery example produces output different from what is shown on website in ET_Tesla ----------------------+----------------------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: closed Priority: blocker | Milestone: ET_2018_02 Component: Other | Version: development version Resolution: fixed | Keywords: Gallery GRHydro regression ----------------------+-----------------------------------------------------

Comment (by knarf):

See also #1642 for reference.