#1753: hwloc: move pkg-config based detection into Search phase -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Keywords: hwloc | -----------------------------------+---------------------------------------- the attacheched patch changes detect.sh such that pkg-config is treated on the same footing as the search at commonly known places. It also adds the option for the user to specify HWLOC_LIBS rather than hard-coding it to hwloc.
#1753: hwloc: move pkg-config based detection into Search phase ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: hwloc ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: new => review
Comment:
If one of the usual suspects would mind to have a look, please. I tested that I can use this version both when pkg-config is present and when HWLOC_DIR is set to BUILD.
#1753: hwloc: move pkg-config based detection into Search phase ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: hwloc ------------------------------------+---------------------------------------
Comment (by knarf):
Also, note that there is another ticket about hwloc: #1717. That's not strictly the same issue, but whoever fixes one should know about the other.
#1753: hwloc: move pkg-config based detection into Search phase ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: hwloc ------------------------------------+---------------------------------------
Comment (by rhaas):
Unless objection are raised I will commit the patch on Wednesday.
#1753: hwloc: move pkg-config based detection into Search phase ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: fixed | Keywords: hwloc ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: review => closed * resolution: => fixed
Comment:
Applied as revision 86 of hwloc
trac@lists.einsteintoolkit.org
-
Einstein Toolkit