#2090: GetComponents should not prompt in a Jupyter notebook ---------------------------+------------------------------------------------ Reporter: sbrandt | Owner: Type: defect | Status: new Priority: unset | Milestone: Component: GetComponents | Version: development version Keywords: | ---------------------------+------------------------------------------------ GetComponents should only prompt if it is in a terminal and not in a Jupyter notebook. The following patch addresses this issue.
#2090: GetComponents should not prompt in a Jupyter notebook ----------------------------+----------------------------------------------- Reporter: sbrandt | Owner: Type: defect | Status: review Priority: unset | Milestone: Component: GetComponents | Version: development version Resolution: | Keywords: ----------------------------+----------------------------------------------- Changes (by rhaas):
* status: new => review
Comment:
Please set the ticket state to "review" if you'd like a patch reviewed.
#2090: GetComponents should not prompt in a Jupyter notebook ----------------------------+----------------------------------------------- Reporter: sbrandt | Owner: Type: defect | Status: reviewed_ok Priority: unset | Milestone: Component: GetComponents | Version: development version Resolution: | Keywords: ----------------------------+----------------------------------------------- Changes (by rhaas):
* status: review => reviewed_ok
Comment:
Looks like a hack. Ideally one would not want to tie this to just jupyter yet it seems impossible to find out if the user could actually respond since jupyter insists on creating a tty (and then does not properly support it since once cannot read from stdin :-( ).
There is a second change in there that now uses {{{$answer}}} instead of "no" in the default shown to the user. This involves no functional change since {{{$answer}}} has already been initialized to "no" at this point and is actually an improvement since it shows the actual default that will be used and not what the author of the code thinks that default was.
So ok to apply to *master only*, please make this two commits, one for the {{{$answer}}} change, one for the jupyter support.
#2090: GetComponents should not prompt in a Jupyter notebook ----------------------------+----------------------------------------------- Reporter: sbrandt | Owner: Type: defect | Status: closed Priority: unset | Milestone: Component: GetComponents | Version: development version Resolution: fixed | Keywords: ----------------------------+----------------------------------------------- Changes (by sbrandt):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Fixed in a26dcd216cf97d6776b10a2fd27fe70cd24259b8 of https://github.com/gridaphobe/CRL.git
trac@lists.einsteintoolkit.org