[Einstein Toolkit] #1936: Multiple tags in EinsteinAnalysis/QuasiLocalMeasures/interface.ccl
#1936: Multiple tags in EinsteinAnalysis/QuasiLocalMeasures/interface.ccl ---------------------+------------------------------------------------------ Reporter: sbrandt | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: Other | Version: development version Keywords: | ---------------------+------------------------------------------------------ Starting on line 94 of EinsteinAnalysis/QuasiLocalMeasures/interface.ccl we see GFs declared with multiple tags. The current behavior of the Cactus compilation system is to ignore all but the last one. Should the first tags be deleted, or should some other change be made?
#1936: Multiple tags in EinsteinAnalysis/QuasiLocalMeasures/interface.ccl ----------------------+----------------------------------------------------- Reporter: sbrandt | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: Other | Version: development version Resolution: | Keywords: ----------------------+-----------------------------------------------------
Comment (by hinder):
This was discussed in http://lists.einsteintoolkit.org/pipermail/users/2016-May/004810.html and http://lists.einsteintoolkit.org/pipermail/users/2016-May/004811.html, where I suggested that the format in the documentation does not allow multiple TAGS entries, and it was a bug to allow them. I suggest to flag this as an error and abort. The current behaviour of ignoring all but the last is absolutely a bug, as it is very unlikely to be what the author intends.
#1936: Multiple tags in EinsteinAnalysis/QuasiLocalMeasures/interface.ccl ----------------------+----------------------------------------------------- Reporter: sbrandt | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: Other | Version: development version Resolution: | Keywords: ----------------------+-----------------------------------------------------
Comment (by sbrandt):
Let me clarify. I have a branch of the flesh called piraha_everywhere where multiple tags now produce a CST error. I'd like for piraha_everywhere to successfully compile the ET. That means fixing this thorn, either removing the extra tag, or concatenating the strings in the tags, or something. My question is, what is the desired fix to this interface.ccl?
#1936: Multiple tags in EinsteinAnalysis/QuasiLocalMeasures/interface.ccl ----------------------+----------------------------------------------------- Reporter: sbrandt | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: Other | Version: development version Resolution: | Keywords: ----------------------+-----------------------------------------------------
Comment (by hinder):
Merge the tags. I can't imagine the author of the thorn intended anything else.
#1936: Multiple tags in EinsteinAnalysis/QuasiLocalMeasures/interface.ccl ----------------------+----------------------------------------------------- Reporter: sbrandt | Owner: Type: defect | Status: closed Priority: minor | Milestone: Component: Other | Version: development version Resolution: fixed | Keywords: ----------------------+----------------------------------------------------- Changes (by sbrandt):
* status: new => closed * resolution: => fixed
Old description:
Starting on line 94 of EinsteinAnalysis/QuasiLocalMeasures/interface.ccl we see GFs declared with multiple tags. The current behavior of the Cactus compilation system is to ignore all but the last one. Should the first tags be deleted, or should some other change be made?
New description:
Starting on line 94 of EinsteinAnalysis/QuasiLocalMeasures/interface.ccl we see GFs declared with multiple tags. The current behavior of the Cactus compilation system is to ignore all but the last one. Should the first tags be deleted, or should some other change be made?
Tags merged.
--
trac@lists.einsteintoolkit.org
-
Einstein Toolkit