#2193: centos.cfg disables OpenMP -------------------------+--------------------------------- Reporter: Roland Haas | Owner: Steven R. Brandt Type: defect | Status: assigned Priority: minor | Milestone: Component: SimFactory | Version: development version Keywords: | -------------------------+--------------------------------- Git commit 2e827ac "Set MPI_DIR so that centos doesn't have to build MPI. Update the recommended yum packages so that libtldl is present." commented out all OpenMP settings in centos.cfg which given that the configure script says
# determine OPENMP_MODE from the OPENMP option # if this option isn't set OPENMP_MODE will default to 'no'
this would mean that the code is not compiled with OpenMP making it impossible to test OpenMP parallelisation using this option list.
#2193: centos.cfg disables OpenMP --------------------------+--------------------------------- Reporter: Roland Haas | Owner: Steven R. Brandt Type: defect | Status: assigned Priority: minor | Milestone: Component: SimFactory | Version: development version Resolution: | Keywords: --------------------------+---------------------------------
Comment (by Steven R. Brandt):
centos.cfg should be deleted.
#2193: centos.cfg disables OpenMP --------------------------+--------------------------------- Reporter: Roland Haas | Owner: Steven R. Brandt Type: defect | Status: assigned Priority: minor | Milestone: Component: SimFactory | Version: development version Resolution: | Keywords: --------------------------+---------------------------------
Comment (by Roland Haas):
Right now it still exists and we are frozen so removing it may be a bit abrupt (even though we are more lenient in simfactory acknowledging that it has to track moving targets), people seem to use it (see Maria's email to the mailing list).
#2193: centos.cfg disables OpenMP --------------------------+--------------------------------- Reporter: Roland Haas | Owner: Steven R. Brandt Type: defect | Status: assigned Priority: minor | Milestone: Component: SimFactory | Version: development version Resolution: | Keywords: --------------------------+---------------------------------
Comment (by Steven R. Brandt):
Right, that's why I didn't actually do it.
#2193: centos.cfg disables OpenMP --------------------------+--------------------------------- Reporter: Roland Haas | Owner: Steven R. Brandt Type: defect | Status: assigned Priority: minor | Milestone: Component: SimFactory | Version: development version Resolution: | Keywords: --------------------------+---------------------------------
Comment (by Steven R. Brandt):
We should tell people to use generic.cfg instead.
#2193: centos.cfg disables OpenMP --------------------------+--------------------------------- Reporter: Roland Haas | Owner: Steven R. Brandt Type: defect | Status: assigned Priority: minor | Milestone: Component: SimFactory | Version: development version Resolution: | Keywords: --------------------------+---------------------------------
Comment (by Roland Haas):
I agree. Will be nice to remove the many almost identical run sub and cfg files.
#2193: centos.cfg disables OpenMP --------------------------+--------------------------------- Reporter: Roland Haas | Owner: Steven R. Brandt Type: defect | Status: assigned Priority: minor | Milestone: Component: SimFactory | Version: development version Resolution: | Keywords: --------------------------+---------------------------------
Comment (by Roland Haas):
So we leave this ticket open and remove after the release? We should then also set a milestone for the release after Wu.
#2193: centos.cfg disables OpenMP --------------------------+--------------------------------- Reporter: Roland Haas | Owner: Steven R. Brandt Type: defect | Status: assigned Priority: minor | Milestone: Component: SimFactory | Version: development version Resolution: | Keywords: --------------------------+---------------------------------
Comment (by Roland Haas):
And add a deprecation warning to the release message (so no one can say they vanished unexpectedly).
#2193: centos.cfg disables OpenMP --------------------------+--------------------------------- Reporter: Roland Haas | Owner: Steven R. Brandt Type: defect | Status: assigned Priority: minor | Milestone: Component: SimFactory | Version: development version Resolution: | Keywords: --------------------------+---------------------------------
Comment (by Roland Haas):
Hmm, it seems no deprecation warning appeared in the release announcement. https://einsteintoolkit.org/about/releases/ET_2018_09_announcement.html
#2193: centos.cfg disables OpenMP --------------------------+--------------------------------- Reporter: Roland Haas | Owner: Steven R. Brandt Type: defect | Status: assigned Priority: minor | Milestone: Component: SimFactory | Version: development version Resolution: | Keywords: --------------------------+---------------------------------
Comment (by Steven R. Brandt):
Probably we should have. However, cfgs in simfactory have always lived by a looser standard than the rest of Cactus.
#2193: centos.cfg disables OpenMP --------------------------+--------------------------------- Reporter: Roland Haas | Owner: Steven R. Brandt Type: defect | Status: assigned Priority: minor | Milestone: Component: SimFactory | Version: development version Resolution: | Keywords: --------------------------+---------------------------------
Comment (by Roland Haas):
For updates sure, for going away, not so much. We can still remove them but really have to tell people in the release announcement how to switch over to generic.XXX then. At least it is a build-time failure and not a run-time failure.
I think we should a milestone for the next release to this ticket so that we do not forget about it. The release ought to be one of 2019_02 or 2019_04 or 2019_05 (depending on "same as last year" or "this release plus 6 months" or "time of this release plus 6 months" :-) ).
#2193: centos.cfg disables OpenMP --------------------------+--------------------------------- Reporter: Roland Haas | Owner: Steven R. Brandt Type: defect | Status: assigned Priority: minor | Milestone: Component: SimFactory | Version: development version Resolution: | Keywords: --------------------------+---------------------------------
Comment (by Roland Haas):
Turns out that this exact question was asked during the phone call (http://lists.einsteintoolkit.org/pipermail/users/2018-October/006547.html) so my objection above should be ignored. Announcing it in the next release should be done.
#2193: centos.cfg disables OpenMP --------------------------+--------------------------------- Reporter: Roland Haas | Owner: Steven R. Brandt Type: defect | Status: closed Priority: minor | Milestone: Component: SimFactory | Version: development version Resolution: duplicate | Keywords: --------------------------+--------------------------------- Changes (by Steven R. Brandt):
* status: assigned => closed * resolution: => duplicate
Comment:
Duplicates ticket 2199, "Cleanup Distros"
trac@lists.einsteintoolkit.org