#1027: close small memory leak in CarpetIOHDF5 --------------------------+------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: defect | Status: new Priority: minor | Milestone: Component: Carpet | Version: Keywords: CarpetIOHDF5 | --------------------------+------------------------------------------------- this patches closes a memory leak in CarpetIOHDF5 when using open_one_input_file_at_a_time, where the HDF5 file would be closed, but the data read out out it was not freed which would cause storage for it to be reallocated again when the file is opened again for the next refinement level. It also properly closes a HDF5 property that was left dangling otherwise.
#1027: close small memory leak in CarpetIOHDF5 ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: eschnett Type: defect | Status: review Priority: minor | Milestone: Component: Carpet | Version: Resolution: | Keywords: CarpetIOHDF5 ---------------------+------------------------------------------------------ Changes (by rhaas):
* status: new => review
#1027: close small memory leak in CarpetIOHDF5 ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: eschnett Type: defect | Status: review Priority: minor | Milestone: Component: Carpet | Version: Resolution: | Keywords: CarpetIOHDF5 ---------------------+------------------------------------------------------
Comment (by eschnett):
Wasn't there an alternative version of this patch that doesn't clear the list of patches, but instead doesn't reconstruct the list when the file is opened again?
#1027: close small memory leak in CarpetIOHDF5 ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: eschnett Type: defect | Status: reviewed_ok Priority: minor | Milestone: Component: Carpet | Version: Resolution: | Keywords: CarpetIOHDF5 ---------------------+------------------------------------------------------ Changes (by eschnett):
* status: review => reviewed_ok
Comment:
Please apply.
#1027: close small memory leak in CarpetIOHDF5 ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: eschnett Type: defect | Status: closed Priority: minor | Milestone: Component: Carpet | Version: Resolution: fixed | Keywords: CarpetIOHDF5 ---------------------+------------------------------------------------------ Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Applied as carpet hash e0af185c8c0b "CarpetIOHDF5: close memory and HDF5 properties leaks mostly associated"
trac@lists.einsteintoolkit.org
-
Einstein Toolkit