#1028: do not re-parse file when using open_one_input_file_at_a_time -------------------------+-------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: enhancement | Status: new Priority: minor | Milestone: Component: Carpet | Version: Keywords: | -------------------------+-------------------------------------------------- this patch retains the patch map created when reading a file even when the file itself is closed due to open_one_input_file_at_a_time. Since parsing the file is slow this can considerably speed up open_one_input_file_at_a_time.
#1028: do not re-parse file when using open_one_input_file_at_a_time --------------------------+------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: enhancement | Status: review Priority: minor | Milestone: Component: Carpet | Version: Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by rhaas):
* status: new => review
#1028: do not re-parse file when using open_one_input_file_at_a_time --------------------------+------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: enhancement | Status: review Priority: minor | Milestone: Component: Carpet | Version: Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by eschnett):
Please apply.
Does the other patch (that clears the list of patches) also have bits that need to be applied, e.g. closing HDF5 properties?
#1028: do not re-parse file when using open_one_input_file_at_a_time --------------------------+------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: enhancement | Status: review Priority: minor | Milestone: Component: Carpet | Version: Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by rhaas):
yes #107 should also be applied. #1027 is a bugfix only patch. That means that something gets added and removed right away. The bugfix patch looked incomplete otherwise. I did not want to make this patch part of bugfix patch (to separate new features from bugfixes).
#1027 contains two necessary fixes: free()ing the filename and closing the HDF5 xfer property. The asserts are optional, the patches.clear() is reverted by this patch.
#1028: do not re-parse file when using open_one_input_file_at_a_time --------------------------+------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: enhancement | Status: review Priority: minor | Milestone: Component: Carpet | Version: Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by eschnett):
In this case, please apply both.
#1028: do not re-parse file when using open_one_input_file_at_a_time --------------------------+------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: Component: Carpet | Version: Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):
* status: review => reviewed_ok
#1028: do not re-parse file when using open_one_input_file_at_a_time --------------------------+------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: enhancement | Status: closed Priority: minor | Milestone: Component: Carpet | Version: Resolution: fixed | Keywords: --------------------------+------------------------------------------------- Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
applied as carpet hash 1089cd7c139d "CarpetIOHDF5: do not re-parse files for patches when using"
trac@lists.einsteintoolkit.org
-
Einstein Toolkit