#968: ignore restricted points in NaNChecker, use OpneMP -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: NaNChecker | -----------------------------------+---------------------------------------- the attached patch 1 adds a new option ignore_restricted_points to NaNChecker which, if set, makes NaNChecker not complain about grid points for which a mask (by default CarpetReduce::weight, but its name is another parameter) is zero. This is useful for hydro runs to not abort a run if a NaN is found on a very coarse level where it will be overwritten afterwards.
The second patch adds OpenMP to NaNChecker. It also converts to code to C++ and uses templates instead of macros.
Both patches pass the testsuite in NanChecker (in their default setting).
#968: ignore restricted points in NaNChecker, use OpneMP ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: NaNChecker ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: new => review
Comment:
OK to apply?
#968: ignore restricted points in NaNChecker, use OpneMP ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: NaNChecker ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: review => reviewed_ok
Comment:
Instead of using a template, you could have used _Pragma instead of #pragma (but this doesn't work with some versions of PGI).
Both patches are okay to apply.
#968: ignore restricted points in NaNChecker, use OpneMP ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: NaNChecker ------------------------------------+---------------------------------------
Comment (by rhaas):
It seems I cannot apply this myself. I get: {{{ "svn-commit.tmp" 7L, 212C written Authentication realm: https://svn.cactuscode.org:443 CactusCode Subversion Repository Password for 'rhaas': svn: Commit failed (details follow): svn: Server sent unexpected return value (500 Internal Server Error) in response to MKACTIVITY request for '/arrangements/CactusUtils/NaNChecker/!svn/act/7a34c55d-bdd2-413e-a7de- 9197062cee1b' svn: Your commit message was left in a temporary file: svn: '/mnt/data/rhaas/postdoc/gr/ET_trunk/arrangements/CactusUtils/trunk/svn- commit.tmp' }}}
#968: ignore restricted points in NaNChecker, use OpneMP ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: NaNChecker ------------------------------------+---------------------------------------
Comment (by eschnett):
Please open a ticket for this -- the svn servers located at the CCT have been acting up for the past week.
#968: ignore restricted points in NaNChecker, use OpneMP ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: NaNChecker ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Applied as r103 and r104 of NaNChecker.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit