#954: Rename configure scripts to "configure.sh" -----------------------------------+---------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: | -----------------------------------+---------------------------------------- Each thorn in ExternalLibraries has a script that configures it. For historic reasons these scripts all have different names. I propose to rename them all to "configure.*", where the suffix denotes the language (e.g. sh or pl).
#954: Rename configure scripts to "configure.sh" ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: new => review
#954: Rename configure scripts to "configure.sh" ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by knarf):
Since the name of the configure script has to be specified in the ccl files anyway this shouldn't be more than a cosmetic change, and a welcome one. Please apply.
#954: Rename configure scripts to "configure.sh" ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: review => reviewed_ok
#954: Rename configure scripts to "configure.sh" ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Done.
#954: Rename configure scripts to "configure.sh" ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: ------------------------------------+---------------------------------------
Comment (by rhaas):
Now that all these scripts (actually it would be nicest if one could use the SCRIPT entry of configuration.ccl) are named configure.sh, would it make sense to add them to the make dependencies? So that the library is rebuild when this file changes? I have no idea how hard to implement this would be.
#954: Rename configure scripts to "configure.sh" ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: ------------------------------------+---------------------------------------
Comment (by eschnett):
Can you open a ticket for this, and add this discussion?
The script itself already checks a few conditions to find out whether the library needs rebuilding. One way would be to add a new DEPENDENCIES output to the script, which the flesh then processes when it decides whether to run the CST.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit