#2070: shallow checkouts do not work with branches ---------------------------+------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: GetComponents | Version: development version Keywords: | ---------------------------+------------------------------------------------ Currently using both --shallow and a branch (rather than master) fails since GetComponents wants to first clone the full repo then switch to the requested branch which fails with a shallow clone.
However newer versions of git (>=1.7) support a "-b" (branch) option for clone and that one works fine even with shallow clones.
My recollection is that we could not use this method initially since there were clusters around that only offered git 1.6 (queenbee likely). This is no longer the case and all clusters in simfactory offer at least git 1.7.
This pull request:
https://github.com/gridaphobe/CRL/pull/6/files
both fixes the problem and simplifies the code.
#2070: shallow checkouts do not work with branches ----------------------------+----------------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: GetComponents | Version: development version Resolution: | Keywords: ----------------------------+----------------------------------------------- Changes (by rhaas):
* status: new => review
#2070: shallow checkouts do not work with branches ----------------------------+----------------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: GetComponents | Version: development version Resolution: | Keywords: ----------------------------+-----------------------------------------------
Comment (by knarf):
As far as I can see, the patch only removes the branch functionality. It doesn't move it to the regular checkout (it doesn't add the mentioned "-b" option there. Wouldn't that leave shallow clones of branches still in master?
#2070: shallow checkouts do not work with branches ----------------------------+----------------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: reopened Priority: minor | Milestone: Component: GetComponents | Version: development version Resolution: | Keywords: ----------------------------+----------------------------------------------- Changes (by rhaas):
* status: review => reopened
Comment:
Hello Frank,
correct. Must have removed it with some other debug code. Will update.
Yours, Roland
trac@lists.einsteintoolkit.org
-
Einstein Toolkit