#693: Check extent of interpolation stencils in CarpetInterp2 ----------------------+----------------------------------------------------- Reporter: eschnett | Owner: eschnett Type: defect | Status: new Priority: critical | Milestone: Component: Carpet | Version: Keywords: | ----------------------+----------------------------------------------------- Do what these comments say in fasterp.cc of CarpetInterp2:
// TODO: assert that there are enough ghost zones
// TODO: store for every face/direction/component/map/reflevel // how wide the boundaries are in every direction. Then check // against this when the stencils are set up.
#693: Check extent of interpolation stencils in CarpetInterp2 -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: eschnett Type: defect | Status: review Priority: critical | Milestone: Component: Carpet | Version: Resolution: | Keywords: -----------------------+---------------------------------------------------- Changes (by eschnett):
* status: new => review
Comment:
The attached patch adds more error checking to CarpetInterp2. Please test this patch if you run multi-patch simulations.
#693: Check extent of interpolation stencils in CarpetInterp2 -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: eschnett Type: defect | Status: review Priority: critical | Milestone: Component: Carpet | Version: Resolution: | Keywords: -----------------------+----------------------------------------------------
Comment (by rhaas):
The logic in lines 963 and 229,289,296 seems inverted. calc_stencil seems to return 0 when everything is fine and -1 upon errors. So the check in 963 should be "if(ierr) { CCTK_Warn... }".
Otherwise harmless it seems. The routines are not used by anything (public) in ET right now either. Please apply (with the change above if correct).
#693: Check extent of interpolation stencils in CarpetInterp2 -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: eschnett Type: defect | Status: review Priority: critical | Milestone: Component: Carpet | Version: Resolution: | Keywords: -----------------------+----------------------------------------------------
Comment (by hinder):
Yes, I discovered the same thing and discussed it on the Llama mailing list. It seems to work fine with multipatch (with that logic change) and could be committed.
#693: Check extent of interpolation stencils in CarpetInterp2 -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: eschnett Type: defect | Status: review Priority: critical | Milestone: Component: Carpet | Version: Resolution: | Keywords: -----------------------+----------------------------------------------------
Comment (by rhaas):
I applied the patch (with that logic change).
#693: Check extent of interpolation stencils in CarpetInterp2 -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: eschnett Type: defect | Status: closed Priority: critical | Milestone: Component: Carpet | Version: Resolution: fixed | Keywords: -----------------------+---------------------------------------------------- Changes (by rhaas):
* status: review => closed * resolution: => fixed
trac@lists.einsteintoolkit.org
-
Einstein Toolkit