#1889: correct finding normalization value for relerr compuation --------------------+------------------------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: major | Milestone: Component: Cactus | Version: development version Keywords: | --------------------+------------------------------------------------------- Before it would have taken the larger of the abs value of the new and old data of the last data set rather than the largest abs value of the new and old data of all the datasets.
This will make relative errros smaller and will be particularly noticeable in cases where the last dataset was small or zero.
This should get rid of the "Error, how did I get here" warnings (that really indicated an logic error).
#1889: correct finding normalization value for relerr compuation ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: review Priority: major | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by rhaas):
* status: new => review
#1889: correct finding normalization value for relerr compuation ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: reopened Priority: major | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by rhaas):
* status: review => reopened
Comment:
I am no longer sure if this is the right fix. Instead it may be better to compute maxrelerr differently (directly when comparing instead of after the fact).
#1889: correct finding normalization value for relerr compuation ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: reopened Priority: minor | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by rhaas):
* priority: major => minor
#1889: correct finding normalization value for relerr compuation --------------------------+--------------------------------- Reporter: Roland Haas | Owner: (none) Type: defect | Status: reopened Priority: minor | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+---------------------------------
Comment (by Roland Haas):
This is conceivably related to http://lists.einsteintoolkit.org/pipermail/users/2018-August/006462.html
trac@lists.einsteintoolkit.org
-
Einstein Toolkit