#1438: do not require --thornlist for build --reconfig --------------------------+------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: enhancement | Status: review Priority: minor | Milestone: Component: SimFactory | Version: development version Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by rhaas):

* status: new => review

#1438: do not require --thornlist for build --reconfig --------------------------+------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: enhancement | Status: review Priority: minor | Milestone: Component: SimFactory | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------

Comment (by rhaas):

Sigh, lost my carefully typed up summary. Here's the shorter one:

The current code checks whether a configs/*/ThornList file exists and stores the result of this check hasStoredThornList however it then forces needThornList to be true for --rebuilds. Hence GetThornList requires an --thornlist option either on the command line or in the machine db. Ie.

{{{ sim build }}} will use the stored thornlist but {{{ sim build --rebuild }}} will not and requires {{{ sim build --rebuild --thornlist configs/sim/ThornList }}}

I am not sure if rebuild will use configs/sim/OptionList or the option list from the machine db (I suspect the later). So the current behaviour is consistent in that --rebuild behaves as if a new configuration was build but it does not match well with how simfactory is actually used and what causes --rebuilds to be required (mostly changes that do not require a new ThornList).

#1438: do not require --thornlist for build --reconfig --------------------------+------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: enhancement | Status: review Priority: minor | Milestone: Component: SimFactory | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------

Comment (by rhaas):

I am not sure I follow, sorry. The proposed code does not force needThornList to be false, it sets it to "not haveStoreThornList". So a --thornlist argument is required for build whenever there is no stored ThornList.

I was not sure what the proposed would do when the ThornList file was missing. Testing this (new code) in a configuration where I first deleted configs/*/ThornList has simfactory abort with: {{{ Error: No thornlist supplied. Use --thornlist <thornlist> on the command line or set thornlist = <thornlist> in the [default] section of defs.local.ini. Aborting Simfactory. }}}

So the change in behaviour occurs only if there is a thornlist specified in the mdb, which has been updated. Then for a configuration where configs/*/ThornList exists and where --thornlist was not used on the command line, the old code would have updated configs/*/ThornList while the new code would use configs/*/ThornList without updating it. It can be argued though that ThornList does not "belong" to simfactory since it's use is defined by the underlying Cactus build system, while OptionList is simfactory's equivalent of config-info. This exposes knowledge of the underlying build system to the user.

#1438: do not require --thornlist for build --reconfig --------------------------+------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: enhancement | Status: closed Priority: minor | Milestone: Component: SimFactory | Version: development version Resolution: fixed | Keywords: --------------------------+------------------------------------------------- Changes (by rhaas):

* status: reviewed_ok => closed * resolution: => fixed

Comment:

Applied as rev 2276 if simfactory.