#1459: ExternalLibraries/PAPI does not build with gcc 4.8.1 ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: PAPI ------------------------------------+---------------------------------------

Comment (by rhaas):

Can be avoided by calling configure like this {{{ CFLAGS=-Wno-error-shadow configures ... }}} which is however gcc specific I believe.

#1459: ExternalLibraries/PAPI does not build with gcc 4.8.1 ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: PAPI ------------------------------------+---------------------------------------

Comment (by rhaas):

It is a warning about shadowed variables and shadowing is in principle allowed in C so there needs not be an actual error. The only reason that the compilation aborts is that PAPI seems to use flags to turn warnings into errors (and presumably that gcc 4.8.1 contains more warnings in -Wall than 4.7 did). As far as I can tell there is no error. The code (schematically) looks like this: {{{ while(foo) { char * endptr; /* no use of endptr*/ if(bar) { char *endptr; strtod(...,&endptr); assert(*endptr == 0); } /* no use of endptr */ if(baz) { strtod(...,&endptr); assert(*endptr == 0); } /* no use of endptr */ } }}} so is correct code and contains no bug. I looked into it a bit more and more proposed solution is probably too radical. There are other warnings- turned-into-errors later on, in particular also one about const-casts in free()'s argument which I can never remove. Essentially what happens is that one has: {{{ struct blah { const char *uname; }; void somefunc(struct blah* b) { free((void*)b->uname); } }}} which triggers the warning since free takes a non-const argument (even though you cannot use the data pointed to by the pointer afterwards anyway).

Setting CFLAGS seems to just overwrite the CFLAGS that configure would use. Does anyone know how to append to the CFLAGS that configure constructs? Something like and --additional-cflags option?

I attach a patch to PAPI and its configure.sh that patches the affected source files (there are multiple other warnings that were turned into errors) during the configuration phase.

I am not sure if newer versions of PAPI compile successfully with gcc 4.8.1 or not.

#1459: ExternalLibraries/PAPI does not build with gcc 4.8.1 ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: PAPI ------------------------------------+---------------------------------------

Comment (by rhaas):

A grep for Werror in Cactus/configs/sim/scratch/build/PAPI/papi-5.1.0 finds it in various places. *However* my own config-info turns on -Wshadow which then gives the error. So one solution is to filter out -Wshadow from Cactus' CFLAGS (or have users not use it together with PAPI). I attach a patch that removes the ones that I had set and the prevented a build. However even with no Cactus set flags it still failes to build {{{ command_line.c: In function 'main': command_line.c:132:5: warning: 'data_type' may be used uninitialized in this function [-Wmaybe-uninitialized] switch (data_type) { }}}

#1459: ExternalLibraries/PAPI does not build with gcc 4.8.1 ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: PAPI ------------------------------------+--------------------------------------- Changes (by rhaas):

* status: new => review

#1459: ExternalLibraries/PAPI does not build with gcc 4.8.1 ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: PAPI ------------------------------------+--------------------------------------- Changes (by eschnett):

* status: review => reviewed_ok

Comment:

Looks good.