#1484: close file handles in CarpetHDF5 reader when VisIt closes files ------------------------+--------------------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: major | Milestone: Component: Other | Version: development version Keywords: CarpetHDF5 | ------------------------+--------------------------------------------------- The VisIt plugin contains some caching logic for the HDF5 file metadata (namely which datasets exist in which file, can be disabled by setting the environment variable CARPETHDF5_CACHE_METADATA to "no"). There is a design flaw in this code that causes it to never close the HDF5 file handle which in turn causes libHDF5 to use up memory and (importantly) to not free the OS file handle. With large runs and many variables it is quite possible to run out of file descriptors.
The attached patch tries to correct this by freeing the HDF5 handle when VisIt closes a file (but keeps the cached metadata in memory).
#1484: close file handles in CarpetHDF5 reader when VisIt closes files ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: review Priority: major | Milestone: Component: Other | Version: development version Resolution: | Keywords: CarpetHDF5 ---------------------+------------------------------------------------------ Changes (by rhaas):
* status: new => review
#1484: close file handles in CarpetHDF5 reader when VisIt closes files ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: major | Milestone: Component: Other | Version: development version Resolution: | Keywords: CarpetHDF5 ---------------------+------------------------------------------------------ Changes (by eschnett):
* status: review => reviewed_ok
Comment:
Nobody seems to feel comfortable enough with this code to review the patch. Please apply.
#1484: close file handles in CarpetHDF5 reader when VisIt closes files ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: closed Priority: major | Milestone: Component: Other | Version: development version Resolution: fixed | Keywords: CarpetHDF5 ---------------------+------------------------------------------------------ Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Applied as rev 55 of CarpetHDF5.
trac@lists.einsteintoolkit.org